#1 Double Headers
Closed 6 years ago Opened 6 years ago by zoglesby.

Sections in the release notes have two headers.

I think removing the section with the header name would make it cleaner.

Example:
[[sect-modularity]] == Fedora Modularity
49B631DF-AA8E-45B2-B354-F40B20621299.jpeg


On second pass this seems to be a site wide issue not just release notes. @bex is this an issue with the asciibinder theme? If so what repo should this issue be against?

@zoglesby I'm on my phone so I haven't verified what I'm saying is what you're reporting, however I think thisnisnit. Asciibinder'sndefault template puts the menu text above the content, separated by a line. Fedora Docs, has by default used the same words for the first header and the menu text.

I believe we should decide if this is what we want or if we should modify one of them to be more expressive in their specific context. If we want to do this, let's open a ticket against https://pagure.io/fedora-docs/docs-fp-o

I believe the file to modify will be https://pagure.io/fedora-docs/docs-fp-o/blob/master/f/_templates/page.html.erb#_59

If we decide to modify it, we will also need to update the individual repos. I'd like to see is build a management program for that to limit duplicative PRs.

So .. some of what I wrote was wrong :)

The double header is because the template prints the first head it finds and then proceeds to render the page. If that first header is an h1 = header, then it is ommitted in the render and there is no double header effect. It appears our first headers are all h2 ==. I think the solution is going to lie in redoing the header levels. This needs to be explored a bit as it generates some warnings we need to think about.

This should definitely get moved over to docs-fp-o in my opinion as it affects all repos. @zoglesby if you have time to move it that would be great. Otherwise I'll try to do it when I have more time.

Metadata Update from @zoglesby:
- Issue status updated to: Closed (was: Open)

6 years ago

Login to comment on this ticket.

Metadata
Attachments 1