PR#273: Publishing a new screenshot for release upgrade from Gnome Software - fedora-docs/quick-docs

fedora-docs / quick-docs

#273 Publishing a new screenshot for release upgrade from Gnome Software

Closed 3 years ago by jflory7. Opened 3 years ago by augenauf.

Unknown source master into master

Update modules/ROOT/pages/upgrading.adoc

Flo H • 3 years ago

2ac7c0d

uploaded new screenshot for Gnome Software dist-upgrade notification

florianh • 3 years ago

e0221b0

Update modules/ROOT/pages/create-hello-world-rpm.adoc

Flo H • 3 years ago

221d321

modules/ROOT/assets/images/Upgradef31f32-gs.png

file added

empty or binary file added

modules/ROOT/pages/create-hello-world-rpm.adoc

file modified

+1 -1

		`@@ -46,7 +46,7 @@`
		`== Building a "Hello World" RPM`

		`We need the source code of the project we are packaging, often referred to as the 'upstream' source.`
		- We will download it from the project's website into the `~/rpmbuild/SOURCE` directory.
		+ We will download it from the project's website into the `~/rpmbuild/SOURCES` directory.
		`We are getting the compressed tarball archive, which happens to be the preferred distribution form for most FOSS projects.`

		`----`

modules/ROOT/pages/upgrading.adoc

file modified

+1 -1

		`@@ -26,7 +26,7 @@`
		`It will download the upgrade files, then prompt for a reboot to install them, similar to a system update.`
		`When the upgrade is complete, the system will automatically reboot into the new release.`

		`- image:Upgradef24f25-gs.png[Upgradef24f25-gs.png,title="Upgradef24f25-gs.png",width=640]`
		`+ image:Upgradef31f32-gs.png[Upgradef31f32-gs.png,title="Release Upgrade Gnome Software",width=640]`

		`[[sect-upgrading-using-the-dnf-system-upgrade-plugin]]`
		`== Upgrading using the DNF System Upgrade plugin`

augenauf commented 3 years ago

Publishing a new screenshot for release upgrade from Gnome Software

ankursinha commented 3 years ago

Looks good. Can you remove the unused Upgradef24f25-gs.png file too please (after checking that it is unused)?

Metadata Update from @ankursinha:
- Request assigned

3 years ago

Metadata Update from @ankursinha:
- Pull-request tagged with: improvement, needs changes, needs committer review

3 years ago

augenauf commented 3 years ago

I was thinking of removing Upgradef24f25-gs.png, however, I don't know any smart method to check if it is referred to elsewhere.

jflory7 commented 3 years ago

I was thinking of removing Upgradef24f25-gs.png, however, I don't know any smart method to check if it is referred to elsewhere.

If you are using Linux or macOS, and have a Terminal with grep, I use this command often:

grep -rnw /path/to/git/repo/modules/ROOT -e "Upgradef24f25-gs.png"

This will parse all of the files in that folder and check if the string "Upgradef24f25-gs.png" appears at all in any of the other documents.

augenauf commented 3 years ago

no other references to that screenshot file found.

augenauf commented 3 years ago

Still learning all the git basics, I messed up my local repo quite a bit (created to many test commits that I now can't get rid off, whatever). I will submit another PR removing the Upgradef24f25-gs.png once this one merged...

augenauf commented 3 years ago

Let's discard and close this one and take a look at https://pagure.io/fedora-docs/quick-docs/pull-request/274

jflory7 commented 3 years ago

Sounds good @augenauf, I will close this one out. Also, you might appreciate @bcotton's guide on git for docs writers!

https://docs.fedoraproject.org/en-US/fedora-docs/contributing/git/