See https://pagure.io/fedora-docs/docs-fp-o/pull-request/178
Thank you! Mostly, this looks great.
I do not like commit build.sh: Update with latest version from template which, unfortunately, makes some things worse. This original works when present working directory path contains whitespace: podman run --rm -it -v "$(pwd):/antora:z" $image $cmd, while the suggested alternative without the quotes does not.
podman run --rm -it -v "$(pwd):/antora:z" $image $cmd
Similar problem may also come from removing the inner quotes from this line: elif [ "$(expr substr $(uname -s) 1 5)" == "Linux" ]; then, depending on if uname -s may contain whitespace.
elif [ "$(expr substr $(uname -s) 1 5)" == "Linux" ]; then
uname -s
(If you really hate quoting, then there are also places in build.sh where they actually can be removed, like "Linux"in the example above. But when it comes to shell, usually more quotes are better than less, for both readability and correct function in presence of strings that contain whitespace.)
build.sh
"Linux"
I would also have used version: ~in antora.yml, because the current value master is now deprecated.
version: ~
antora.yml
master
I will pull in the other commits and submit a pull request for the template to fix the mentioned issues. After the template is good again, we can then update this repo to match it.
The PR: template/pull-request/20
Closing this now, if you think that the commit I dropped really should be merged, please open a new one and explain the situation.
Pull-Request has been closed by oturpe
AS explained in the README, everybody whose pull request is merged gets commit privileges, so I am adding those for you now.
Thanks for the feedback here! I'll take a look at your PR.
See https://pagure.io/fedora-docs/docs-fp-o/pull-request/178