Do you think we need to note that if people have multiple ssh keys, they should configure their ~/.ssh/config file like this:

HOST *.fedoraproject.org fedorapeople.org *.pagure.io *.fedorainfracloud.org
    IdentityFile ~/.ssh/<fedora private ssh key file>
    User <fedora username>
    AddKeysToAgent yes        

Or is that perhaps too advanced, and folks that use multiple keys will know this already?

Link to this wiki page on creating SSH keys?

https://fedoraproject.org/wiki/Cryptography#OpenSSH

(looks fine, but perhaps could later be moved to quick docs or something)

Oddly enough, I don't have this file here, and everything still works fine. Not sure where it picks up my username from, maybe the kerberos ticket or another location?

Worth linking to https://pagure.io/FedoraReview ? (So folks know where it is developed etc.?)

Looks very good, a few minor comments, but please feel free to make the necessary updates and then merge your changes when you're ready :thumbsup:

Do you think we need to note that if people have multiple ssh keys, they should configure their ~/.ssh/config file
(snip)
Or is that perhaps too advanced, and folks that use multiple keys will know this already?

Link to this wiki page on creating SSH keys?

https://fedoraproject.org/wiki/Cryptography#OpenSSH

(looks fine, but perhaps could later be moved to quick docs or something)

My scope here was to just unify the existing instructions,
so I did not even try improving anything.
Probably it would make sense to give better instructions for ssh key handling.

On the other hand, that task is very generic, needed for other things than Fedora Package Management too.
So, probably the right thing to do is to link somewhere where proper explanation is given,
then just fill in details about Fedora's domains and other specifics.
For now, I will add a link to the wiki page you found, which is much better than nothing.
This can be further improved in the future.

Oddly enough, I don't have this file here, and everything still works fine. Not sure where it picks up my username from, maybe the kerberos ticket or another location?

I have also been wondering what it is actually needed for.
The only thing I am aware of is fedora-easy-karma.
I am quite certain that if it is used for anything that is needed for package maintenance,
you would have ran into some problems.
So, I will just remove that part now.
Let's put it back in with a better explanation if it turns out to be needed.

Just a final check: Do you have the same username on your local machine and FAS?
At least fedora-easy-karma defaults to the local username if it does not find .fedora.upn.
That could also explain why things work for you.

Worth linking to https://pagure.io/FedoraReview ? (So folks know where it is developed etc.?)

Done.

Than you for the review! Merging this now.

No, my local username does not match my FAS username, so I'm really not sure where it gets picked up from. For repos from src.fp.o, I thought it picked up from the git remote URL, but I also think it picks up from the kinit token and so on.

I see I have a ~/.config/fedora.toml file, where I've got:

[FAS]
username = "ankursinha"

but I can't remember what tool this is for XD

Ah---that's used by fedora-update-feedback:

https://github.com/ironthree/fedora-update-feedback

(which notes that fedora.upn is legacy)

Thank you for checking.
I am now quite certain that fedora.upn is not needed for packaging work.

Explaining all the different config files somewhere could be useful,
but that is a separate topic.