#179 Include `Resolves:` in commit message to autoclose review ticket
Opened by vondruch. Modified
fedora-docs/ vondruch/package-maintainer-docs resolves-in-commit-message  into  main

Download 179.patch

I think it would be nice to let automation do its job and if I am not mistaken, Bodhi should be able to close the review ticket if Resolves (or similar) is properly mentioned in commit message (but I have missed to test this on real life new package :/, so I hope there is not some issue).

If the ticket is closed by Bodhi, there is no reason to have section about closing BZ review ticket. However, it could be reformulate into something like "check if the review ticket was closed by automation". But automation should just work without any supervision of users, right?

I have realized now, that there is "If your package is using __autochangelog__, writing the bug number as specified will make Bodhi automatically close the bug when your package is submitted to Rawhide stable repository." Not sure how autochangelog would differ from regular changelog, but that certainly have not worked for my package, that is the reason I come here to propose this change:

https://src.fedoraproject.org/rpms/rubygem-propshaft/c/a6787165f3e5a1ff743ea125c5e3db35ac6fe085?branch=rawhide

Chm, maybe Bodhi is looking at (fedora#nnnnnn) in changelog, which I have missed?

Yes, changelog is the place where Bodhi is looking at for the bug ID. At least this form works, because I use it all the time:

Update to X.Y.Z (rhbz#NNNNNN)

And I also remember that there are other keys than rhbz. So unless is has been confirmed that the given instructions do not work, I would avoid changing anything.

The multi-line syntax you propose does not work, because rpmautospec has its own rules for picking up what is copied to changelog and what is not. If the message is split into multiple lines, it needs to be done after a fashion that is compatible with rpmautospec's parsing rules.

So the auto-closing of bugs is done by Bodhi, and depends on having changelogs formatted in certain way. Since we do not actually strictly require using that form (via rpmautospec or otherwise), and it is possible to make a mistake there, I think it is good to have a step about it. But that should it should also mention the automation.

One thing I noticed is that while the existing contributors page mentions closing the ticket, there is nothing about that in the new contributors page. In the Review Process page there is a mention.

I can adjust this, unless you feel like doing it?

I can adjust this, unless you feel like doing it?

I'd appreciate if you did that. But I think both guidelines should point people toward using automation and just double checking if it did what it is supposed to do.

I can adjust this, unless you feel like doing it?

I'd appreciate if you did that. But I think both guidelines should point people toward using automation and just double checking if it did what it is supposed to do.

Thank you, I will!

Metadata