#19 Import Creating RPM Packages material from Quick Docs
Closed 2 years ago by oturpe. Opened 2 years ago by oturpe.

Fedora Quick Docs current has page Creating RPM Packages.
This material actually is better located at Package Maintainer Docs.
It was just put to Quick Docs
because the Package Maintainer Docs did not exist at the time.
Import page and its sub-pages,
leave only links pointing to the new location behind.


I have created patches for those changes and temporary stored them on a public github repo.

https://github.com/iagorubio/fedora-docs

If that is a problem please let me know and I will move them to other place.

Thank you for your contribution,
it is very much appreciated!

It is not a problem to store patches in any place you prefer.
This repository itself is public
and is intended to be maintained in public,
so using any public location is acceptable.

However,
there is a preference to use Pagure's fork-and-pull-request workflow
because that gives us
automatic rebases,
diff view on the web page,
commenting on individual lines
and so forth.

Anyhow, some comments follow:

  1. Please squash the commits when fixing errors in previous commits,
    like is done in patch 2/2.
    This way Git history stays clean and readable.
  2. In order to get clean diffs when material is updated,
    this repository uses semantic linebreaks.
    Source material does not have them,
    is it too much to ask for you to perform the conversion?
  3. Using link: in front of urls is allowed by Asciidoc,
    but kind of unnecessary.
    The rest of the material does not use them,
    could you remove them here also?

Metadata Update from @oturpe:
- Issue assigned to iago

2 years ago

I have a first version ready to go with:

  • Commits squashed.
  • Semantic linebreaks - most docs were fine. The docs still need to be checked out to see if I got a grasp of it or I got it wrong.
  • Removed link:

I will send a PR if it's the preferred method to push changes.

Please take it with a pinch of salt and check it thoroughly. I am not familiar with asciidoc and even while it builds and seems fine on my end, it may be I am missing something.

It's not a problem to drop all changes, clone again and start over.

Created PR https://pagure.io/fedora-docs/package-maintainer-docs/pull-request/22

Hopefully everything is ok, but please let me know any improvements I can make.

Don't hesitate to reject it, if you think it may be improved.

The remaining useful parts from Quick Docs were imported in 4f490ad.
This issue has been resolved.

Metadata Update from @oturpe:
- Issue status updated to: Closed (was: Open)

2 years ago

Login to comment on this ticket.

Metadata