From 16c440e4113ffcd614b5d1a6ed21c7cd32f86d9b Mon Sep 17 00:00:00 2001 From: Adam Samalik Date: Jan 23 2019 10:59:55 +0000 Subject: [PATCH 1/3] Update 'managing defaults and fedora changes' --- diff --git a/modules/ROOT/pages/making-modules/managing-defaults.adoc b/modules/ROOT/pages/making-modules/managing-defaults.adoc index 2a7d876..dedeb77 100644 --- a/modules/ROOT/pages/making-modules/managing-defaults.adoc +++ b/modules/ROOT/pages/making-modules/managing-defaults.adoc @@ -1,14 +1,17 @@ = Managing module defaults in Fedora -Setting or changing a *default stream* or a *default installation profile* of a module is in most cases similar to changing a major version of a package. Setting or changing the default stream or the default installation profile requires a Fedora Change request, and it is only allowed in between Fedora releases. +Setting or changing a *default stream* or a *default installation profile* of a module is in most cases similar to changing a major version of a package. The following rules apply: + +1. Module stream defaults should be only changed in anupcoming Fedora release +2. Changes of stream defaults should be communicated by a Fedora Change based on the change's significance and its maintainer's best judgement. +3. No default stream changes mid-release are permitted. +4. Introducing a new default stream not replacing any existing default stream or a traditional package is not considered a change. That means it can be done. == Setting or changing a default -Submit an issue to Fedora Release Engineering in https://pagure.io/releng/issues[pagure.io/releng]. You also need to https://fedoraproject.org/wiki/Changes/Policy#For_developers[submit a Fedora Change]. +Submit an issue to Fedora Release Engineering in https://pagure.io/releng/issues[pagure.io/releng]. Consider https://fedoraproject.org/wiki/Changes/Policy#For_developers[submiting a Fedora Change]. To check the current defaults, have a look at the https://pagure.io/releng/fedora-module-defaults[fedora module defaults repository]. -Setting or changing default stream of a module will be considered based on the following rules: +Please note that if the module stream masks part of the Traditional RPM repos (e.g it replaces an existing RPM or it introduces a non-trivial set of conflicts) it may not be made a default stream without the express permission of FESCo. Release Engineering will be responsible for escalating any PR that is questionable on this point to FESCo for a final decision. -* If the module stream does not mask any part of the Traditional RPM repos, it may be set as a default stream. For example, any module that is entirely a leaf or one that fulfills the function of a package moved from the traditional repos into the modular repos (e.g. `nodejs:8` might replace the `nodejs` traditional package) -* If the module stream masks part of the Traditional RPM repos (e.g it replaces an existing RPM or it introduces a non-trivial set of conflicts) it may not be made a default stream without the express permission of FESCo. Release Engineering will be responsible for escalating any PR that is questionable on this point to FESCo for a final decision. From 7ea484c7a15f47e18e47814c7558389a3b5c69dd Mon Sep 17 00:00:00 2001 From: Adam Samalik Date: Jan 23 2019 11:51:09 +0000 Subject: [PATCH 2/3] typo --- diff --git a/modules/ROOT/pages/making-modules/managing-defaults.adoc b/modules/ROOT/pages/making-modules/managing-defaults.adoc index dedeb77..dbd9012 100644 --- a/modules/ROOT/pages/making-modules/managing-defaults.adoc +++ b/modules/ROOT/pages/making-modules/managing-defaults.adoc @@ -2,7 +2,7 @@ Setting or changing a *default stream* or a *default installation profile* of a module is in most cases similar to changing a major version of a package. The following rules apply: -1. Module stream defaults should be only changed in anupcoming Fedora release +1. Module stream defaults should be only changed in an upcoming Fedora release 2. Changes of stream defaults should be communicated by a Fedora Change based on the change's significance and its maintainer's best judgement. 3. No default stream changes mid-release are permitted. 4. Introducing a new default stream not replacing any existing default stream or a traditional package is not considered a change. That means it can be done. From 5ce5ba4651cc38427d45fe1ae447bf51481bfe99 Mon Sep 17 00:00:00 2001 From: Adam Samalik Date: Jan 31 2019 12:14:18 +0000 Subject: [PATCH 3/3] better phrasing in managing defaults --- diff --git a/modules/ROOT/pages/making-modules/managing-defaults.adoc b/modules/ROOT/pages/making-modules/managing-defaults.adoc index dbd9012..84e9bb1 100644 --- a/modules/ROOT/pages/making-modules/managing-defaults.adoc +++ b/modules/ROOT/pages/making-modules/managing-defaults.adoc @@ -1,15 +1,15 @@ = Managing module defaults in Fedora -Setting or changing a *default stream* or a *default installation profile* of a module is in most cases similar to changing a major version of a package. The following rules apply: +Setting or changing a default stream or a default installation profile of a module constitutes a major behavior change as defined in the Fedora Updates Policy. The following rules apply: -1. Module stream defaults should be only changed in an upcoming Fedora release -2. Changes of stream defaults should be communicated by a Fedora Change based on the change's significance and its maintainer's best judgement. -3. No default stream changes mid-release are permitted. +1. Module stream defaults MUST be only changed in an upcoming Fedora release +2. Changes of stream defaults should be communicated by a Fedora Change based on the change's significance and its maintainer's best judgement. When in doubt, file a Change. +3. Changes of the default stream of a module are not permitted within a released Fedora without the approval of FESCo. 4. Introducing a new default stream not replacing any existing default stream or a traditional package is not considered a change. That means it can be done. == Setting or changing a default -Submit an issue to Fedora Release Engineering in https://pagure.io/releng/issues[pagure.io/releng]. Consider https://fedoraproject.org/wiki/Changes/Policy#For_developers[submiting a Fedora Change]. +Submit an issue to Fedora Release Engineering in https://pagure.io/releng/issues[pagure.io/releng]. Consider https://fedoraproject.org/wiki/Changes/Policy#For_developers[submiting a Fedora Change]. Please specify which releases of Fedora should have which streams/profiles by default in the initial ticket. To check the current defaults, have a look at the https://pagure.io/releng/fedora-module-defaults[fedora module defaults repository].