#1 Adapt modules/ROOT/pages/troubleshooting.adoc to change in module-build-service-2.19
Closed a year ago by tpopela. Opened 5 years ago by sbergmann.
fedora-docs/ sbergmann/flatpak master  into  master

@@ -20,6 +20,9 @@ 

                                       'fedpkg --release module sources'),

  }

  ....

+ This no longer works with `module-build-service-2.19`, and while

+ https://pagure.io/fm-orchestrator/issue/1211[file:///full-path in DISTGITS stopped working with module-build-service-2.19.0-1.fc29.noarch] isn't yet fixed.

+ As a workaround, instead of doing the above changes to `/etc/module-build-service/config.py`, do `fedpkg prep` (after doing your changes below).

  

  * Edit your `<application>.yaml` and add a repository line:

  

no initial comment

(While the "Edit this Page" link at https://docs.fedoraproject.org/en-US/flatpak/troubleshooting/ makes it relatively easy to type your edit into a web page, there appears to be no preview feature there, so I have no idea whether my additions are actually properly marked-up.)

Do you know if this ever got merged? I see the diff is empty (3 years later :))

From my old local repo clone, this was apparently

commit 028604e32568e929d62c5f9ff7f609cfb5ceb1e5
Author: Stephan Bergmann <sbergman@redhat.com>
Date:   Thu Apr 11 12:01:56 2019 +0000

    Adapt modules/ROOT/pages/troubleshooting.adoc to change in module-build-service-2.19

diff --git a/modules/ROOT/pages/troubleshooting.adoc b/modules/ROOT/pages/troubleshooting.adoc
index b627f38..83aa494 100644
--- a/modules/ROOT/pages/troubleshooting.adoc
+++ b/modules/ROOT/pages/troubleshooting.adoc
@@ -3,40 +3,43 @@
 == Module build problems

 == Rebuilding a module against a local component
 If you find a build problem with a component in your module, you'll want to build
 the module using a local git checkout for the module, so you can put fixes in there:

 * Checkout the module from dist-git using `fedpkg clone` as a subdirectory of `<path to checkouts>`
 * **Unless you are using https://github.com/owtaylor/fedora-packager-container[fedora-packager-container]**,
   edit your `/etc/module-build-service/config.py`
   change `RPMS_ALLOW_REPOSITORY = False` to `RPMS_ALLOW_REPOSITORY = True`,
   and at the end, add:

 ....
 LocalBuildConfiguration.DISTGITS = {
     'https://src.fedoraproject.org': ('fedpkg clone --anonymous {}',
                                      'fedpkg --release module sources'),
     'file:///<path to checkouts>/': ('git clone file:///<path to checkouts>/{0}; git -C {0} remote set-url origin ssh://<username>@pkgs.fedoraproject.org/rpms/{0}',
                                      'fedpkg --release module sources'),
 }
 ....
+This no longer works with `module-build-service-2.19`, and while
+https://pagure.io/fm-orchestrator/issue/1211[file:///full-path in DISTGITS stopped working with module-build-service-2.19.0-1.fc29.noarch] isn't yet fixed.
+As a workaround, instead of doing the above changes to `/etc/module-build-service/config.py`, do `fedpkg prep` (after doing your changes below).

 * Edit your `<application>.yaml` and add a repository line:

 [source,yaml]
 ----
     rpms:
       libpeas:
         repository: file:///<path to checkouts>/libpeas
         rationale: Runtime dependency
         ref: f33
 ----

 * Use `fedpkg switch-branch` to switch to the rfe from `<application.yaml>` (or change the `ref:` in `<application.yaml`> to be `master`)
 * Make your changes and **commit them**
 * Try building your module again

 === Quickly debugging prefix=/app builds
 If you hit a problem where a component fails to build with prefix=/app and you need to debug in detail,
 as a shortcut, you can *temporarily*
 `dnf install ~/modulebuild/cache/koji_tags/module-flatpak-runtime-f33-<latest-version>/flatpak-rpm-macros-*.x86_64.rpm`,

on top of https://pagure.io/fedora-docs/flatpak/c/ba36d98e70d4396012e3db1e0eaa06458b887417 "- old fedora versions bump to fedora 33", and which has apparently never been merged.

However, it presumably was meanwhile obsoleted by https://pagure.io/fedora-docs/flatpak/c/4b1d742e71f2b1e83a68f518e0554afff8a8333e "Update modules/ROOT/pages/troubleshooting.adoc: Update the part for the local module builds."

I don't really remember anything about this, and if @tpopela doesn't either, lets close this for good.

This shouldn't be needed - what's in https://docs.fedoraproject.org/en-US/flatpak/troubleshooting/#_rebuilding_a_module_against_a_local_component was all that was needed for F36 (unless something didn't regress in meantime).

Pull-Request has been closed by tpopela

a year ago
Metadata