PR#54: Fix README - fedora-docs/fedora-docs-ui

fedora-docs / fedora-docs-ui

#54 Fix README

Closed 2 years ago by oturpe. Opened 2 years ago by oturpe.

fedora-docs/ oturpe/fedora-docs-ui readme-fixes into master

Otto Urpelainen • 2 years ago

44fcf10

README.md

file modified

+2 -3

		`@@ -18,13 +18,12 @@`

		```
		`$ git clone https://pagure.io/fedora-docs/fedora-docs-ui.git`
		`- $ antora-ui-test`
		```

		`Install the project dependencies:`

		```
		`- $ antora-ui-builder yarn install`
		`+ $ antora-ui-builder install`
		```

		You also need to make a slight change to the configuration of your project so it works in a container. Open the `gulpfile.js` and add one new line `host: "0.0.0.0",` right below `port: 5252,` as shown below:
		`@@ -50,7 +49,7 @@`
		`Build a live preview:`

		```
		`- $ antora-ui-builder gulp preview`
		`+ $ antora-ui-builder preview`
		```

		`Preview it on [localhost:5252](http://localhost:5252).`

oturpe commented 2 years ago

Command antora-ui-test does not exist,
and seems not to be needed in that position
Subcommands of antora-ui-builder seem to have changed,
changed to versions that actually exist.

oturpe commented 2 years ago

Even after these fixes,
I am unable to work with this repository,
but I do not know how to fix the error I receive:

$ antora-ui-builder preview
gulp preview[1]: ../src/node_contextify.cc:649:static void node::contextify::ContextifyScript::New(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `args[1]->IsString()' failed.
 1: 0x7f8f70ae9d4c node::Abort() [/lib64/libnode.so.72]
 2: 0x7f8f70aea082 node::Assert(node::AssertionInfo const&) [/lib64/libnode.so.72]
 3: 0x7f8f70adc358 node::contextify::ContextifyScript::New(v8::FunctionCallbackInfo<v8::Value> const&) [/lib64/libnode.so.72]
 4: 0x7f8f70eb07b5 v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo) [/lib64/libnode.so.72]
 5: 0x7f8f70eb10d7  [/lib64/libnode.so.72]
 6: 0x7f8f70eb13b8  [/lib64/libnode.so.72]
 7: 0x7f8f70eb16ed v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [/lib64/libnode.so.72]
 8: 0x7f8f719485b9  [/lib64/libnode.so.72]

Edited 2 years ago by oturpe

darknao commented 2 years ago

I've updated the README with a new set of instructions which I believe should solve your issue.
On the other hand, it also means this PR may not be valid anymore.

darknao commented 2 years ago

I've updated the README with a new set of instructions which I believe should solve your issue.
On the other hand, it also means this PR may not be valid anymore.

oturpe commented 2 years ago

Thank you, the new system works just by following README.
Closing this issue now.

Pull-Request has been closed by oturpe

2 years ago