PR#38: feat: update IRC links to libera - fedora-docs/documentation-contributors-guide

fedora-docs / documentation-contributors-guide

#38 feat: update IRC links to libera

Closed 2 years ago by pbokoc. Opened 2 years ago by ankursinha.

fedora-docs/ ankursinha/documentation-contributors-guide feat/issue-36 into master

feat: use Libera.chat web-chat

Ankur Sinha (Ankur Sinha Gmail) • 2 years ago

c73eb20

feat: update IRC links to libera

Ankur Sinha (Ankur Sinha Gmail) • 2 years ago

faec68c

modules/ROOT/pages/index.adoc

file modified

+1 -1

		`@@ -25,7 +25,7 @@`
		`The Fedora Docs team uses the following communication platforms:`

		`Mailing list:: {MAILING-LIST}[{MAILING-LIST}]`
		`- IRC channel:: link:ircs://chat.freenode.net:6697/#fedora-docs[#fedora-docs] on https://freenode.net/[Freenode IRC]`
		`+ IRC channel:: link:https://web.libera.chat/?channels=#fedora-docs[#fedora-docs] on https://libera.chat[Libera.chat]`
		`Matrix room:: {MATRIX}[#fedora-docs:matrix.org]`
		`Telegram group:: {TELEGRAM}[@fedora_docs]`

modules/contributing/pages/contributing-to-existing-docs.adoc

file modified

+1 -1

		`@@ -84,7 +84,7 @@`

		`[NOTE]`
		`====`
		- If nobody reacts to your pull request in several days, try bringing it up on one of the link:++https://apps.fedoraproject.org/calendar/docs/++[weekly meetings], the IRC channel (`#fedora-docs` on FreeNode), or the link:++https://lists.fedoraproject.org/archives/list/docs@lists.fedoraproject.org/++[mailing list].
		`+ If nobody reacts to your pull request in several days, try bringing it up on one of the link:++https://apps.fedoraproject.org/calendar/docs/++[weekly meetings], the IRC channel (link:https://web.libera.chat/?channels=#fedora-docs[#fedora-docs] on https://libera.chat[Libera.chat]), or the link:++https://lists.fedoraproject.org/archives/list/docs@lists.fedoraproject.org/++[mailing list].`
		`====`

		`Your changes will appear online sometime after the pull request is merged.`

ankursinha commented 2 years ago

Fixes https://pagure.io/fedora-docs/documentation-contributors-guide/issue/36

thunderbirdtr commented 2 years ago

Hello o/ friendly ping* :) @nb @pbokoc. may we check and merge this (we already moved our chats) a quick look and merge would be awesome :)

For PR, looks lgtm to me :)

jflory7 commented on line 6 of modules/ROOT/pages/index.adoc 2 years ago

There is a protocol mismatch on this line. See ircs://https://. The ircs:// part needs to be omitted.

Metadata Update from @jflory7:
- Pull-request tagged with: needs changes, type - existing docs
- Request assigned

2 years ago

ankursinha commented 2 years ago

I didn't touch that bit at all---that's how it was and I'm not sure if that's intentional or not. Is it not? (I thought maybe that allows the link to open in a locally installed IRC client, though it doesn't work for me here on a terminal based weechat)

pbokoc commented 2 years ago

ircs:// links will try to join the server and open the channel in your locally installed IRC client, the https:// link goes to webchat - but you can't use both protocols at the same time, that's the problem. Let's either do a link to LiberaChat's webchat and remove the ircs://, or do it like before and use only ircs://, but not both.

1 new commit added

feat: use Libera.chat web-chat

2 years ago

ankursinha commented 2 years ago

Sounds good. Updated.

pbokoc commented 2 years ago

Hmmm. Looks like we forgot about this PR and in the meantime that part has been updated to link to Matrix and the ML link now goes to Discourse, so I'll close this.