#9 In general, removing an HTML page and going to the directory level should not give a 403
Opened 4 years ago by mattdm. Modified 3 months ago

Going from e.g. https://docs.fedoraproject.org/f26/release-notes/sysadmin/Kernel.html to
https://docs.fedoraproject.org/f26/release-notes/sysadmin/ gives a 403 error. This looks sloppy. Doing this should take you up one step in the navigation, just like clicking one step back in the cookie-crumbs navigation.

As I understand the structure, though, the above should take you to https://docs.fedoraproject.org/f26/release-notes/sysadmin/Modularity.html, which is a little odd. Apparently each level of the tree does not have its own node?

I think probably we want to do this with redirects, so that there is a canonical name for each document — that is, https://docs.fedoraproject.org/f26/release-notes/sysadmin/ should redirect to https://docs.fedoraproject.org/f26/release-notes/sysadmin/overview.html or whatever.


Did you get the 403 by clicking a link or by editing the URL in your browser?

There are not index pages in arbitrary folders by default. If we want we can enforce this.

The links now have index.htmls, so these links will work:

https://docs.fedoraproject.org/f26/install-guide/
https://docs.fedoraproject.org/f26/system-administrators-guide/

After the next publish

I am not sure what to do about the nodes. We can put info pages back in, but in my opinion they don't add a lot of value. WDYT?

Is something still needing done on this ticket? I am not sure what @bex is referring to in his last update about "nodes", but everything looks to be working on the production site.

Edit: I should have looked a bit more, you are speaking of the /f26/ portion of the url. Correct?

Is something still needing done on this ticket? I am not sure what @bex is referring to in his last update about "nodes", but everything looks to be working on the production site.
Edit: I should have looked a bit more, you are speaking of the /f26/ portion of the url. Correct?

I believe @mattdm is referring to the sub-level portion of the URL i.e.

https://docs.fedoraproject.org/f26/release-notes/sysadmin/

@mattdm ???

We can do this with the alias functionality. See the example in the _topic_map.yml in https://pagure.io/Fedora-Council/council-docs/blob/master/f/_topic_map.yml

Metadata Update from @bex:
- Issue tagged with: easyfix

4 years ago

Nice. Let's

  1. Make sure that's in the example we give out when setting up new repos
  2. Put a check for it in the CI

Metadata Update from @darknao:
- Issue priority set to: Low
- Issue tagged with: tooling

3 months ago

This came up on the docs meeting during backlog cleanup.

The only times this happens is when the source repo is using topics (subdirectories under modules/<module-name>/pages/), which IIRC only happens in Release Notes, Install Guide, and Sysadmin Guide, and (rarely) in Quick Docs, and only when the topic directory doesn't have its own index file. If you're on a page within a topic and you delete a part of the URL, you get a 403. For anything that's not a topic you just end up a level (or few) above.

It should be fixable just by adding a page alias as described in antora docs. If that works (I'll check later, I'm just making notes right now), we can add indexes with redirects to all topic directories and that'll fix the problem forever. In that case we need to document that in contributor docs in case someone wants to use topics in another repo, too.
If it doesn't work, we could add a dummy index page that just says "Pick a topic from the menu on the left" or something like that, because the repo's table of contents will still be there and it's better than a generic error page.

Metadata Update from @pbokoc:
- Issue untagged with: tooling
- Issue priority set to: None (was: Low)

3 months ago

Metadata Update from @pbokoc:
- Issue priority set to: Low
- Issue tagged with: tooling

3 months ago

Login to comment on this ticket.

Metadata
Boards 1
Tooling Status: Backlog