PR#777: Add a critical-path-server group - fedora-comps

fedora-comps

#777 Add a critical-path-server group

Merged a year ago by adamwill. Opened 2 years ago by adamwill.

adamwill/fedora-comps critpath-server into main

Add a critical-path-server group

Adam Williamson • a year ago

f38d1fd

comps-f35.xml.in

file modified

+17 -1

		`@@ -649,7 +649,7 @@`
		`<!--`
		`Note: The critical-path-* groups are used to identify the packages`
		`that are critical to the health of the distro. For details see:`
		`- https://fedoraproject.org/wiki/Critical_Path_Packages_Proposal`
		`+ https://fedoraproject.org/wiki/Critical_path_package`
		`@core is also considered part of the Critical Path.`
		`-->`
		`<group>`
		`@@ -791,6 +791,22 @@`
		`</packagelist>`
		`</group>`
		`<group>`
		`+ <id>critical-path-server</id>`
		`+ <_name>Critical Path (Server)</_name>`
		`+ <_description>A set of packages that provide the Critical Path functionality for the Server edition</_description>`
		`+ <default>false</default>`
		`+ <uservisible>false</uservisible>`
		`+ <packagelist>`
		`+ <packagereq>freeipa-server</packagereq>`
		`+ <packagereq>bind-dyndb-ldap</packagereq>`
		`+ <packagereq>cockpit</packagereq>`
		`+ <packagereq>freeipa-server-dns</packagereq>`
		`+ <packagereq>freeipa-server-trust-ad</packagereq>`
		`+ <packagereq>opendnssec</packagereq>`
		`+ <packagereq>postgresql</packagereq>`
		`+ </packagelist>`
		`+ </group>`
		`+ <group>`
		`<id>critical-path-standard</id>`
		`<_name>Critical Path (standard)</_name>`
		`<!-- not all deliverables include @standard, critical-path-base only includes stuff from @base -->`

comps-f36.xml.in

file modified

+17 -1

		`@@ -649,7 +649,7 @@`
		`<!--`
		`Note: The critical-path-* groups are used to identify the packages`
		`that are critical to the health of the distro. For details see:`
		`- https://fedoraproject.org/wiki/Critical_Path_Packages_Proposal`
		`+ https://fedoraproject.org/wiki/Critical_path_package`
		`@core is also considered part of the Critical Path.`
		`-->`
		`<group>`
		`@@ -791,6 +791,22 @@`
		`</packagelist>`
		`</group>`
		`<group>`
		`+ <id>critical-path-server</id>`
		`+ <_name>Critical Path (Server)</_name>`
		`+ <_description>A set of packages that provide the Critical Path functionality for the Server edition</_description>`
		`+ <default>false</default>`
		`+ <uservisible>false</uservisible>`
		`+ <packagelist>`
		`+ <packagereq>freeipa-server</packagereq>`
		`+ <packagereq>bind-dyndb-ldap</packagereq>`
		`+ <packagereq>cockpit</packagereq>`
		`+ <packagereq>freeipa-server-dns</packagereq>`
		`+ <packagereq>freeipa-server-trust-ad</packagereq>`
		`+ <packagereq>opendnssec</packagereq>`
		`+ <packagereq>postgresql</packagereq>`
		`+ </packagelist>`
		`+ </group>`
		`+ <group>`
		`<id>critical-path-standard</id>`
		`<_name>Critical Path (standard)</_name>`
		`<!-- not all deliverables include @standard, critical-path-base only includes stuff from @base -->`

comps-f37.xml.in

file modified

+17 -1

		`@@ -640,7 +640,7 @@`
		`<!--`
		`Note: The critical-path-* groups are used to identify the packages`
		`that are critical to the health of the distro. For details see:`
		`- https://fedoraproject.org/wiki/Critical_Path_Packages_Proposal`
		`+ https://fedoraproject.org/wiki/Critical_path_package`
		`@core is also considered part of the Critical Path.`
		`-->`
		`<group>`
		`@@ -782,6 +782,22 @@`
		`</packagelist>`
		`</group>`
		`<group>`
		`+ <id>critical-path-server</id>`
		`+ <_name>Critical Path (Server)</_name>`
		`+ <_description>A set of packages that provide the Critical Path functionality for the Server edition</_description>`
		`+ <default>false</default>`
		`+ <uservisible>false</uservisible>`
		`+ <packagelist>`
		`+ <packagereq>freeipa-server</packagereq>`
		`+ <packagereq>bind-dyndb-ldap</packagereq>`
		`+ <packagereq>cockpit</packagereq>`
		`+ <packagereq>freeipa-server-dns</packagereq>`
		`+ <packagereq>freeipa-server-trust-ad</packagereq>`
		`+ <packagereq>opendnssec</packagereq>`
		`+ <packagereq>postgresql</packagereq>`
		`+ </packagelist>`
		`+ </group>`
		`+ <group>`
		`<id>critical-path-standard</id>`
		`<_name>Critical Path (standard)</_name>`
		`<!-- not all deliverables include @standard, critical-path-base only includes stuff from @base -->`

comps-f38.xml.in

file modified

+17 -1

		`@@ -625,7 +625,7 @@`
		`<!--`
		`Note: The critical-path-* groups are used to identify the packages`
		`that are critical to the health of the distro. For details see:`
		`- https://fedoraproject.org/wiki/Critical_Path_Packages_Proposal`
		`+ https://fedoraproject.org/wiki/Critical_path_package`
		`@core is also considered part of the Critical Path.`
		`-->`
		`<group>`
		`@@ -767,6 +767,22 @@`
		`</packagelist>`
		`</group>`
		`<group>`
		`+ <id>critical-path-server</id>`
		`+ <_name>Critical Path (Server)</_name>`
		`+ <_description>A set of packages that provide the Critical Path functionality for the Server edition</_description>`
		`+ <default>false</default>`
		`+ <uservisible>false</uservisible>`
		`+ <packagelist>`
		`+ <packagereq>freeipa-server</packagereq>`
		`+ <packagereq>bind-dyndb-ldap</packagereq>`
		`+ <packagereq>cockpit</packagereq>`
		`+ <packagereq>freeipa-server-dns</packagereq>`
		`+ <packagereq>freeipa-server-trust-ad</packagereq>`
		`+ <packagereq>opendnssec</packagereq>`
		`+ <packagereq>postgresql</packagereq>`
		`+ </packagelist>`
		`+ </group>`
		`+ <group>`
		`<id>critical-path-standard</id>`
		`<_name>Critical Path (standard)</_name>`
		`<!-- not all deliverables include @standard, critical-path-base only includes stuff from @base -->`

adamwill commented 2 years ago

Following the mailing list discussion where folks mostly seemed
OK with the idea of broadening the critical path definition a
little:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/PLMXRKKDYNJN2LBPJEJBWWA3HL6W2FVC/
this adds a Server critpath definition which is basically the
freeipa-server group, plus cockpit and postgresql.

Signed-off-by: Adam Williamson awilliam@redhat.com

adamwill commented 2 years ago

Of course, this also updates the wiki link to point to a better page.

adamwill commented 2 years ago

Also note, this PR by itself won't cause any real change - we also have to update the critpath.py generation script to list this group. It also needs updating to list several other groups that were added in comps but not to the script, in fact.

adamwill commented 2 years ago

@pboy

rebased onto a5305e6d04bd6f0a2b8df8c022e044427292d331

a year ago

humaton commented a year ago

I have updated the critpath.py with missing groups https://pagure.io/releng/pull-request/11146

rebased onto d91dfb2552a0b4b31bf37dc7185cfd40a5f28d83

a year ago

adamwill commented a year ago

I intentionally was not going to do that yet, for reasons explained in that PR.

We can probably merge this now, though, since nobody objected. I was holding off for the F37 freeze. I guess I should actually add this for F35 and F36 too, really. I'll update the PR.

rebased onto f38d1fd

a year ago

Pull-Request has been merged by adamwill

a year ago