PR#764: Update KDE critical path definition for F37 and Rawhide - fedora-comps

fedora-comps

#764 Update KDE critical path definition for F37 and Rawhide

Merged 2 years ago by kevin. Opened 2 years ago by adamwill.

adamwill/fedora-comps critical-path-kde into main

Update KDE critical path definition for F37 and Rawhide

Adam Williamson • 2 years ago

c0d7d6b

comps-f37.xml.in

file modified

+18

		`@@ -740,7 +740,25 @@`
		`<default>false</default>`
		`<uservisible>false</uservisible>`
		`<packagelist>`
		`+ <packagereq type="mandatory">bluedevil</packagereq>`
		`+ <packagereq type="mandatory">kactivitymanagerd</packagereq>`
		`+ <packagereq type="mandatory">kdecoration</packagereq>`
		`<packagereq type="mandatory">kdelibs</packagereq>`
		`+ <packagereq type="mandatory">kinfocenter</packagereq>`
		`+ <packagereq type="mandatory">kscreen</packagereq>`
		`+ <packagereq type="mandatory">kscreenlocker</packagereq>`
		`+ <packagereq type="mandatory">kwayland-integration</packagereq>`
		`+ <packagereq type="mandatory">kwin</packagereq>`
		`+ <packagereq type="mandatory">layer-shell-qt</packagereq>`
		`+ <packagereq type="mandatory">plasma-breeze</packagereq>`
		`+ <packagereq type="mandatory">plasma-desktop</packagereq>`
		`+ <packagereq type="mandatory">plasma-discover</packagereq>`
		`+ <packagereq type="mandatory">plasma-integration</packagereq>`
		`+ <packagereq type="mandatory">plasma-nm</packagereq>`
		`+ <packagereq type="mandatory">plasma-systemsettings</packagereq>`
		`+ <packagereq type="mandatory">plasma-thunderbolt</packagereq>`
		`+ <packagereq type="mandatory">plasma-workspace</packagereq>`
		`+ <packagereq type="mandatory">polkit-kde</packagereq>`
		`<packagereq type="mandatory">qt5-qtwayland</packagereq>`
		`<packagereq type="mandatory">sddm</packagereq>`
		`</packagelist>`

comps-f38.xml.in

file modified

+18

		`@@ -732,7 +732,25 @@`
		`<default>false</default>`
		`<uservisible>false</uservisible>`
		`<packagelist>`
		`+ <packagereq type="mandatory">bluedevil</packagereq>`
		`+ <packagereq type="mandatory">kactivitymanagerd</packagereq>`
		`+ <packagereq type="mandatory">kdecoration</packagereq>`
		`<packagereq type="mandatory">kdelibs</packagereq>`
		`+ <packagereq type="mandatory">kinfocenter</packagereq>`
		`+ <packagereq type="mandatory">kscreen</packagereq>`
		`+ <packagereq type="mandatory">kscreenlocker</packagereq>`
		`+ <packagereq type="mandatory">kwayland-integration</packagereq>`
		`+ <packagereq type="mandatory">kwin</packagereq>`
		`+ <packagereq type="mandatory">layer-shell-qt</packagereq>`
		`+ <packagereq type="mandatory">plasma-breeze</packagereq>`
		`+ <packagereq type="mandatory">plasma-desktop</packagereq>`
		`+ <packagereq type="mandatory">plasma-discover</packagereq>`
		`+ <packagereq type="mandatory">plasma-integration</packagereq>`
		`+ <packagereq type="mandatory">plasma-nm</packagereq>`
		`+ <packagereq type="mandatory">plasma-systemsettings</packagereq>`
		`+ <packagereq type="mandatory">plasma-thunderbolt</packagereq>`
		`+ <packagereq type="mandatory">plasma-workspace</packagereq>`
		`+ <packagereq type="mandatory">polkit-kde</packagereq>`
		`<packagereq type="mandatory">qt5-qtwayland</packagereq>`
		`<packagereq type="mandatory">sddm</packagereq>`
		`</packagelist>`

adamwill commented 2 years ago

I've had a ticket for this for months:
https://pagure.io/fedora-kde/SIG/issue/171
but it really needs doing so we are testing and gating critical
KDE updates, so I just went ahead and came up with something.
This is based on the recent Plasma 5.24.5 update for Fedora 35,
I just went through the packages in that and picked out the
ones that looked most critical.

Signed-off-by: Adam Williamson awilliam@redhat.com

rebased onto c0d7d6b

2 years ago

ngompa commented 2 years ago

:thumbsup:

Pull-Request has been merged by kevin

2 years ago

siosm commented 2 years ago

Looks good. Thanks!

kkofler commented 2 years ago

This ends up pulling a lot of packages into the critical path through transitive dependencies. E.g., qt5-qtwebengine, qt5-qtmultimedia, and even the deprecated qt5-qtwebkit.

Back when I was a KDE SIG member, we used to deliberately keep the critical-path-kde list as short as possible to avoid dragging in the world through dependencies and hence not forcing the stricter update policies for critical path packages on too many packages. E.g., in KDE 4 times, we basically had only kdm in it, which actually resolved to kdebase-workspace, but not its many dependencies.

ngompa commented 2 years ago

QtWebEngine is a core dependency for Plasma now, unfortunately.

kkofler commented 2 years ago

Well, it being broken SHOULD not make Plasma unbootable. I would still love to figure out where the heck the dependency chain in the backtrace in https://bugzilla.redhat.com/show_bug.cgi?id=2144200 comes from, where Plasma is calling into QtPDF (which is built using PDFium and hence from the QtWebEngine SRPM) when it is supposed to display a plain JPEG or PNG image for which Qt has decoders in qtbase. Because that really looks like a bug to me.