#707 Replace ibus-cangjie with ibus-table-chinese-cangjie
Merged 2 years ago by sgallagh. Opened 2 years ago by mfabian.
mfabian/fedora-comps add-ibus-table-chinese-cangjie  into  main

file modified
+2 -2
@@ -3032,7 +3032,6 @@ 

        <packagereq type="conditional" requires="qt">ibus-qt</packagereq>

        <packagereq type="conditional" requires="xfce4-panel">im-chooser-xfce</packagereq>

        <packagereq type="default">ibus-anthy</packagereq>

-       <packagereq type="default">ibus-cangjie-engine-cangjie</packagereq>

        <packagereq type="default">ibus-hangul</packagereq>

        <packagereq type="default">ibus-libpinyin</packagereq>

        <packagereq type="default">ibus-libzhuyin</packagereq>
@@ -3046,7 +3045,6 @@ 

        <packagereq type="optional">fcitx</packagereq>

        <packagereq type="optional">gcin</packagereq>

        <packagereq type="optional">ibus-bogo</packagereq>

-       <packagereq type="optional">ibus-cangjie-engine-quick</packagereq>

        <packagereq type="optional">ibus-fbterm</packagereq>

        <packagereq type="optional">ibus-handwrite</packagereq>

        <packagereq type="optional">ibus-input-pad</packagereq>
@@ -3056,6 +3054,8 @@ 

        <packagereq type="optional">ibus-skk</packagereq>

        <packagereq type="optional">ibus-table</packagereq>

        <packagereq type="optional">ibus-table-chinese-array</packagereq>

+       <packagereq type="optional">ibus-table-chinese-cangjie</packagereq>
tagoh commented 2 years ago

Why is this "optional"? the purpose of this PR was to install ibus-table-chinese-cangjie by default instead of ibus-cangjie-engine-cangjie right? That looks wrong to me.

+       <packagereq type="optional">ibus-table-chinese-quick</packagereq>

        <packagereq type="optional">ibus-table-cyrillic</packagereq>

        <packagereq type="optional">input-pad</packagereq>

        <packagereq type="optional">scim-anthy</packagereq>

Looks fine, but should not be merged before https://pagure.io/fesco/issue/2737 is approved.

rebased onto 1e476affdc382132d77ce8c62f4e6bcbcb542000

2 years ago

rebased onto dda5ff5

2 years ago

Pull-Request has been merged by sgallagh

2 years ago

Why is this "optional"? the purpose of this PR was to install ibus-table-chinese-cangjie by default instead of ibus-cangjie-engine-cangjie right? That looks wrong to me.

Metadata