#676 Drop memtest86+ from Fedora 35+ (#1988142)
Merged 8 months ago by adamwill. Opened 8 months ago by adamwill.
adamwill/fedora-comps no-memtest86  into  main

file modified
-1
@@ -5690,7 +5690,6 @@ 

      <default>false</default>

      <uservisible>false</uservisible>

      <packagelist>

-       <packagereq>memtest86+</packagereq>

        <packagereq>syslinux</packagereq>

      </packagelist>

    </group>

file modified
-1
@@ -5690,7 +5690,6 @@ 

      <default>false</default>

      <uservisible>false</uservisible>

      <packagelist>

-       <packagereq>memtest86+</packagereq>

        <packagereq>syslinux</packagereq>

      </packagelist>

    </group>

It doesn't work - see also devel@ thread "replace memtest86+ with
pcmemtest, needs maintainer". Until we sort out pcmemtest or some
other replacement, let's just get rid of it. The image creation
tools should smoothly omit the menu entry at creation time if
the package is not there.

Signed-off-by: Adam Williamson awilliam@redhat.com

Will image composes work without this package? Or will lorax blow up because we don't have it available?

@bcl lorax ok with this?
otherwise I'm +1

I checked livecd-tools (which is set up to just not add the memtest boot menu entry if the files aren't there), but didn't check lorax. it does have some stuff, so I'll check that next week to see if it needs adjusting.

@chrismurphy and @ngompa are correct that we shouldn't merge this without checking lorax would be OK with it, though. I am going to check that, but didn't today as it was a holiday.

Lorax will need to be updated for this. I'll work up a PR today. The config files are not conditional, and the x85.tmpl expects a boot/memtest* to be present so things will go sideways if the package is dropped before it has been changed.

I've pushed and built this for rawhide. I see we're in F35 Beta freeze, so it'll wait until after Beta or someone can propose it as a blocker, etc. if they want.

lorax build is queued for stable and I will push it soon, so merging this.

rebased onto 0eea3ca

8 months ago

Pull-Request has been merged by adamwill

8 months ago
Metadata