PR#649: remove dhcp-client from comps groups - fedora-comps

fedora-comps

#649 remove dhcp-client from comps groups

Closed 2 years ago by kevin. Opened 3 years ago by dustymabe.

dustymabe/fedora-comps dusty-dhcp-client into main

remove dhcp-client from comps groups

Dusty Mabe • 3 years ago

c4700eb

comps-f35.xml.in

file modified

-5

		`@@ -569,7 +569,6 @@`
		`<packagereq type="mandatory">bash</packagereq>`
		`<packagereq type="mandatory">coreutils</packagereq>`
		`<packagereq type="mandatory">curl</packagereq>`
		`- <packagereq type="mandatory">dhcp-client</packagereq>`
		`<packagereq type="mandatory">dnf</packagereq>`
		`<packagereq type="mandatory">e2fsprogs</packagereq>`
		`<packagereq type="mandatory">filesystem</packagereq>`
		`@@ -4047,9 +4046,6 @@`
		`<default>false</default>`
		`<uservisible>false</uservisible>`
		`<packagelist>`
		`- <!-- This is the preferred DHCP client so that NetworkManager won't`
		`- fall back to the internal one in full installations. -->`
		`- <packagereq type="default">dhcp-client</packagereq>`
		`<!-- required for IPv4 connection sharing ("Hotspot") to work -->`
		`<packagereq type="default">dnsmasq</packagereq>`
		`<!-- required for IPv4 connection sharing ("Hotspot") to work -->`
		`@@ -4832,7 +4828,6 @@`
		`<packagereq type="mandatory">PackageKit</packagereq>`
		`<packagereq type="mandatory">polkit</packagereq>`
		`<packagereq type="mandatory">realmd</packagereq>`
		`- <packagereq type="default">dhcp-client</packagereq>`
		`<packagereq type="default">fedora-release-server</packagereq>`
		`<packagereq type="default">NetworkManager-team</packagereq>`
		`</packagelist>`

dustymabe commented 3 years ago

NetworkManager has an internal client that we can use. It'd be nice
to drop dhclient if we can.

dustymabe commented 3 years ago

Note: this probably needs a Change Proposal sent out. I'm mostly proposing this change here to spark some discussion on the topic and to find out what all we need to do first.

Edited 3 years ago by dustymabe

kevin commented 2 years ago

I'm in favor. Do you want to submit a change and/or at least discuss on devel list in case there are cases we missed?

bcotton commented 2 years ago

I think a self-contained Change proposal for F35 is the right course of action here.

kevin commented 2 years ago

@dustymabe any progress here?

pbrobinson commented 2 years ago

I actually don't think this requires a change proposal. It's not been used by NetworkManager for some time, nor systemd-networkd, it's now and for a few releases just including a piece of software for the sake of it, do we need a change proposal for the sake of it too?

bcotton commented 2 years ago

If it hasn't been used by default for a while, I'm fine with not submitting a Change proposal for it (especially since the deadline has passed). But it should definitely be included in the release notes.

dustymabe commented 2 years ago

I can send an email to devel list and then what are the next steps? Just merge this and update release notes?