PR#569: f34: Add i3, i3-extended, i3-desktop-environment COMPs - fedora-comps

fedora-comps

#569 f34: Add i3, i3-extended, i3-desktop-environment COMPs

Merged 3 years ago by mohanboddu. Opened 3 years ago by jflory7.

jflory7/fedora-comps add/i3 into main

f34: Add i3, i3-extended, i3-desktop-environment COMPs

Justin W. Flory (he/him) • 3 years ago

e838211

comps-f34.xml.in

file modified

+68

		`@@ -2882,6 +2882,53 @@`
		`</packagelist>`
		`</group>`
		`<group>`
		`+ <id>i3</id>`
		`+ <_name>i3 window manager</_name>`
		`+ <_description>i3 is a tiling window manager primarily targeted at advanced users and developers. This group is a minimal, lightweight group of packages to use i3wm with other system components.</_description>`
		`+ <default>false</default>`
		`+ <uservisible>false</uservisible>`
		`+ <packagelist>`
		`+ <packagereq type="mandatory">i3</packagereq>`
		`+ <packagereq type="mandatory">i3lock</packagereq>`
		`+ <packagereq type="mandatory">i3status</packagereq>`
		`+ <packagereq type="mandatory">dunst</packagereq>`
		`+ <packagereq type="mandatory">lightdm</packagereq>`
		`+ <packagereq type="mandatory">lightdm-gtk</packagereq>`
		`+ <packagereq type="mandatory">lightdm-gtk-greeter-settings </packagereq>`
		`+ <packagereq type="mandatory">nmcli</packagereq>`
		`+ <packagereq type="mandatory">network-manager-applet</packagereq>`
		`+ <packagereq type="mandatory">pactl</packagereq>`
		`+ <packagereq type="mandatory">pavucontrol</packagereq>`
		`+ <packagereq type="mandatory">volumeicon</packagereq>`
		`+ <packagereq type="mandatory">xbrightlight</packagereq>`
		`+ <packagereq type="mandatory">mousepad</packagereq>`
		`+ <packagereq type="default">azote</packagereq>`
		`+ <packagereq type="default">dmenu</packagereq>`
		`+ <packagereq type="default">firefox</packagereq>`
		`+ <packagereq type="default">htop</packagereq>`
		`+ </packagelist>`
		`+ </group>`
		`+ <group>`
		`+ <id>i3-extended</id>`
		`+ <_name>i3 window manager (supplemental packages)</_name>`
		`+ <_description>i3 is a tiling window manager primarily targeted at advanced users and developers. This group includes supplemental, optional packages for the i3 window manager.</_description>`
		`+ <default>false</default>`
		`+ <uservisible>false</uservisible>`
		`+ <packagelist>`
		`+ <packagereq type="default">rofi</packagereq>`
		`+ <packagereq type="default">powertop</packagereq>`
		`+ <packagereq type="default">arandr</packagereq>`
		`+ <packagereq type="default">conky</packagereq>`
		`+ <packagereq type="default">i3status-rs</packagereq>`
		`+ <packagereq type="default">alacritty</packagereq>`
		`+ <packagereq type="default">tmux</packagereq>`
		`+ <packagereq type="default">xarchiver</packagereq>`
		`+ <packagereq type="default">qutebrowser</packagereq>`
		`+ <packagereq type="default">py3status</packagereq>`
		`+ <packagereq type="default">lxappearance</packagereq>`
		`+ </packagelist>`
		`+ </group>`
		`+ <group>`
		`<id>input-methods</id>`
		`<_name>Input Methods</_name>`
		`<_description>Input method packages for the input of international text.</_description>`
		`@@ -5976,6 +6023,27 @@`
		`</optionlist>`
		`</environment>`
		`<environment>`
		`+ <id>i3-desktop-environment</id>`
		`+ <name>i3 desktop</name>`
		`+ <grouplist>`
		`+ <groupid>admin-tools</groupid>`
		`+ <groupid>base-x</groupid>`
		`+ <groupid>core</groupid>`
		`+ <groupid>dial-up</groupid>`
		`+ <groupid>fonts</groupid>`
		`+ <groupid>hardware-support</groupid>`
		`+ <groupid>i3</groupid>`
		`+ <groupid>input-methods</groupid>`
		`+ <groupid>multimedia</groupid>`
		`+ <groupid>networkmanager-submodules</groupid>`
		`+ <groupid>standard</groupid>`
		`+ <groupid>printing</groupid>`
		`+ </grouplist>`
		`+ <optionlist>`
		`+ <groupid>i3-extended</groupid>`
		`+ </optionlist>`
		`+ </environment>`
		`+ <environment>`
		`<id>lxde-desktop-environment</id>`
		`<_name>LXDE Desktop</_name>`
		`<_description>LXDE is a lightweight X11 desktop environment designed for computers with low hardware specifications like netbooks, mobile devices or older computers.</_description>`

jflory7 commented 3 years ago

This commit makes four new additions to the Fedora 34 comps file:

Adds i3 package group: Minimal, base set of packages required to run the i3 window manager
Adds i3-extended package group: Supplemental, optional packages for advanced users who want several different tools available to use
Adds i3-desktop-environment environment: Groups together a base system similar to other desktop environments.
Adds i3-desktop-environment category: Adds a category that appears in the Anaconda installer for new Fedora installs.

Pending discussion on the devel@lists.fp.o mailing list.

CC: @x3mboy @nasirhm @defolos @odilhao @siddharthvipul1

pbrobinson commented 3 years ago

LGTM

jflory7 commented 3 years ago

Devel thread started: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/CK75CIMK764ERLJCYENXWNGU6EJOVRPP/

nasirhm commented 3 years ago

LGTM, Thank you for working on it @jflory7

odilhao commented 3 years ago

LGTM

Thank you for working on this @jflory7

adamwill commented on line 95 of comps-f34.xml.in 3 years ago

this duplication looks unintended and incorrect.

adamwill commented on line 58 of comps-f34.xml.in 3 years ago

Perhaps we should call it "i3 desktop"? I think we should be careful using the word "workstation", especially Capitalized, for things that aren't actually Fedora Workstation.

adamwill commented 3 years ago

BTW, just for reference, the installer does not actually use the "categories". It uses the environment groups. I think only some package managers use the "categories" these days.

sudopluto commented 3 years ago

just a heads up i think the master branch got renamed to main

kevin commented 3 years ago

I edited the pr to be against main. ;)

@jflory7 if you could address adamw's comments we can get this in. ;) We will likely also need some changes in pungi-fedora to compose it, but we can do that after the ks is in place.

ngompa commented on line 15 of comps-f34.xml.in 3 years ago

You need a greeter package with lightdm in order for it to work. Please select one and put it in this group.

Edited 3 years ago by ngompa

odilhao commented 3 years ago

Hi @ngompa would lightdm-gtk be a valid choise? Do we need to add the lightdm-gtk-greeter-settings as well?

ngompa commented 3 years ago

@odilhao If that's what you want to use, then yes.

x3mboy commented on line 15 of comps-f34.xml.in 3 years ago

ligthdm-gtk is installed as dependency. @ngompa Does it need to be listed explicitly?

ngompa commented 3 years ago

You need to pick one, because there are multiple options that satisfy the lightdm-greeter dependency.

rebased onto e2895c4a7dcbac7a2458948446537c7821b93718

3 years ago

1 new commit added

i3: Address @adamw and @ngompa feedback in fedora-comps#569

3 years ago

jflory7 commented 3 years ago

I rebased on latest main and pushed commit 830a97e224c9236cac2cf737610703a551693b9e to address @adamw and @ngompa's feedback:

    This is a follow-up that addresses the following feedback:

    1. Remove deprecated category for i3-desktop-environment
    2. Change "i3 Workstation" to "i3 desktop" in Anaconda
    3. Add lightdm-gtk as default greeter for lightdm-greeter

    This should now be ready to merge.

ngompa commented on line 98 of comps-f34.xml.in 3 years ago

Why is LXDE getting deleted?

1 new commit added