#561 Add fprintd-pam to new critical-path-standard group
Merged 3 years ago by mohanboddu. Opened 3 years ago by adamwill.
adamwill/fedora-comps fprintd-critpath  into  main

file modified
+1
@@ -686,6 +686,7 @@ 

        <packagereq type="mandatory">dbus-broker</packagereq>

        <packagereq type="mandatory">dnf</packagereq>

        <packagereq type="mandatory">dracut</packagereq>

+       <packagereq type="mandatory">fprintd-pam</packagereq>

        <packagereq type="mandatory">gcc-c++</packagereq>

        <packagereq type="mandatory">initial-setup</packagereq>

        <!-- 'kernel' is listed because we need to ensure that kernel

file modified
+1
@@ -658,6 +658,7 @@ 

        <packagereq type="mandatory">dbus-broker</packagereq>

        <packagereq type="mandatory">dnf</packagereq>

        <packagereq type="mandatory">dracut</packagereq>

+       <packagereq type="mandatory">fprintd-pam</packagereq>

        <packagereq type="mandatory">gcc-c++</packagereq>

        <packagereq type="mandatory">initial-setup</packagereq>

        <!-- 'kernel' is listed because we need to ensure that kernel

file modified
+11
@@ -755,6 +755,17 @@ 

      </packagelist>

    </group>

    <group>

+     <id>critical-path-standard</id>

+     <_name>Critical Path (standard)</_name>

+     <!-- not all deliverables include @standard, critical-path-base only includes stuff from @base -->

+     <_description>A set of packages that relate to Critical Path functionality and are in standard but not base</_description>

+     <default>false</default>

+     <uservisible>false</uservisible>

+     <packagelist>

+       <packagereq type="mandatory">fprintd-pam</packagereq>

+     </packagelist>

+   </group>

+   <group>

      <id>critical-path-xfce</id>

      <_name>Critical Path (Xfce)</_name>

      <_description>A set of packages that provide the Critical Path functionality for the Xfce desktop</_description>

We had a situation with an fprintd update that broke su and
console logins:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-f997de7d0e
so clearly fprintd should be on the critical path. This is my
best guess as to how we should best do this (will discuss
details in the PR).

Signed-off-by: Adam Williamson awilliam@redhat.com

So we have an issue of "what to put where" here.

fprintd-pam is listed in @standard, @gnome-desktop and @kde-desktop. As far as the last two are concerned we could just add it to @critical-path-gnome and @critical-path-kde, but it being in @standard seems difficult because there's no corresponding @critical-path-standard. You don't get fprintd-pam in a minimal install, but you do get it in for e.g. a Server install or anything else that pulls in @standard.

So only including it in the KDE and GNOME critpath groups seems wrong, but this also seems weird as we're putting something in the critical-path-base group that isn't actually in a minimal install at all.

I don't think it currently matters practically to a huge degree, but you know me, I like to get things 'right' :D

We probably should have a critical-path-standard group to correspond with the others, it sounds like...

rebased onto c8b154de3803ad956ac3e02c11242d18905c19e9

3 years ago

So, should we just merge this for now? Or try and make a new group?

since there's no magic tooling to hook it up to, I guess just making a new group would be ok. When I made this I was assuming there was already a Magic Critpath-O-Tron that we'd need to patch a new group into. I'll update the PR.

rebased onto 4d813c5cb94393122ee2f378b0ee1a7b4891606f

3 years ago

rebased onto 26a2ac1fa9348ca1eec0ba4b5ca719ec0403db28

3 years ago

rebased onto 6e8f511

3 years ago

Pull-Request has been merged by mohanboddu

3 years ago