#488 Drop obsolete KDE4 software
Merged 3 years ago by humaton. Opened 3 years ago by appadeia.
appadeia/fedora-comps jpontaoski/improved-kde  into  main

file modified
-2
@@ -714,7 +714,6 @@ 

      <default>false</default>

      <uservisible>false</uservisible>

      <packagelist>

-       <packagereq type="mandatory">kdelibs</packagereq>

        <packagereq type="mandatory">sddm</packagereq>

      </packagelist>

    </group>
@@ -3152,7 +3151,6 @@ 

        <packagereq>kscreenlocker</packagereq>

        <packagereq>ksshaskpass</packagereq>

        <packagereq>kwalletmanager5</packagereq>

-       <packagereq>kwebkitpart</packagereq>

        <packagereq>kwin</packagereq>

        <packagereq>kwrite</packagereq>

        <packagereq>NetworkManager-config-connectivity-fedora</packagereq>

KDE4 software is dropped from KDE comps

paging @rdieter, @kkofler, and @jgrulich for feedback from KDE SIG on adjusted package set

The packages that you are removing should be made optional, not removed entirely, so that users can still find them in dnfdragora. Except of course for Firefox, which is not a KDE application and just does not belong there, and which can already be found in the appropriate comps group.

Replacing Dragon Player with VLC is a no go because VLC is not in Fedora (but in RPM Fusion). I also do not think replacing the KDE application Dragon Player with the non-KDE (Qt-only) application VLC makes sense as a default to begin with. But it is not possible anyway.

Please see the issues #204 and #205.

Replacing Dragon Player with VLC is a no go because VLC is not in Fedora (but in RPM Fusion). I also do not think replacing the KDE application Dragon Player with the non-KDE (Qt-only) application VLC makes sense as a default to begin with. But it is not possible anyway.

Ah whoops, forgot that.

Please see the issues #204 and #205.

Will do.

First of all, thanks for looking into this!

Items 1 and 5 are ok, the others are not. If you update this to include only removing the deprecations, I'll approve.

The rest of the changes require at least more discussion, or cannot be done at all (per Kevin's prior feedback).

1 new commit added

  • Address feedback
3 years ago

The rest of the changes require at least more discussion, or cannot be done at all (per Kevin's prior feedback).

Ok then, let's start the discussion.

For Firefox -> Falkon:
1) Falkon is a KDE project designed to fit in with a KDE experience.
2) Firefox has known problematic interactions with KDE integration, e.g. bad support for GTK theming causing issues with Breeze GTK and extension APIs not being adequate enough for p-b-i to function as well as it does on Chrome/ium or Falkon's built-in integration.

For dropping Krusader:
We already ship Dolphin, which is also a file manager. Shipping two file managers isn't ideal UX, and saying that Dolphin offers a better UX for most users than Krusader is an uncontroversial statement.

PR is not for discussion, please use
https://lists.fedoraproject.org/archives/list/kde@lists.fedoraproject.org/

And please do not mix multiple issues into a single PR. Again, if this PR is limited to just cleaning up the old/deprecated stuff, I'll be happy to merge it. Otherwise, no.

3 new commits added

  • Reduce scope of PR
  • Revert "Adjust KDE groups"
  • Revert "Address feedback"
3 years ago

For Firefox -> Falkon:
1) Falkon is a KDE project designed to fit in with a KDE experience.
2) Firefox has known problematic interactions with KDE integration, e.g. bad support for GTK theming causing issues with Breeze GTK and extension APIs not being adequate enough for p-b-i to function as well as it does on Chrome/ium or Falkon's built-in integration.

+1! I have been asking for this for ages. I really do not see why Firefox is installed by default on the KDE Spin and even less why the default application settings in kde-settings prefer it to Falkon as a default browser. So I do not see why this change even needs discussion at all.

The remaining parts of this pull request are very few:

  • removal of kdelibs (4) from the critical path. This clearly makes sense. (What surprises me, though, is that we do not have anything from the Plasma 5 stack in there, only SDDM.)
  • removal of kwebkitpart from the default installation. Given that Konqueror now ships with KWebEnginePart by default, we really do not need kwebkitpart installed by default anymore, but it should be marked as optional rather than deleted entirely.
  • replacement of kwrite with kate. I am not convinced about this one. The main difference between KWrite and Kate is the session management that Kate has, and I find that an annoyance more than a help. KWrite is more of a basic, no surprises text editor. And yet it also offers most of Kate's features, being based on the same editor component (the KatePart). So I am not convinced that we really want the full Kate by default.

PS: Once again: please see issue #204. Comps groups should not be just lists, but every package in the list should be classified as mandatory, default, or optional. Things that we do not want installed by default should still be listed as optional. So we usually do not want lines simply deleted (except in some cases such as the critical path list, or such as non-KDE applications that have snuck into KDE groups), they should be made optional instead.

Many useful KDE applications in Fedora are missing in comps and should be marked optional in some group. That is mostly what #204 is about. But at least do not make things worse by deleting more packages from comps.

I guess we're left with a pretty small PR, I was basing my comments on the PR description without looking at the actual changes. That said, original description hadn't mentioned kwrite/kate, so that change should be omitted as well from here as well.

1 new commit added

  • Use kwrite
3 years ago

So, is this ready to merge now? Could the submitter squash things down so we can see whats changing? Or should we just close this and open new ones for particular changes?

I'm ok with the content of the pull request, though I would echo kevin's feedback that squashing the commits would be preferable.

rebased onto f56c317832d57059f010d540f45f9f5efe421df3

3 years ago

@appadeia can you squash your commits here down to one? git rebase -i and a git push --force should do it?

rebased onto 626c7ce6a5677e99d43f4b7f862bde19c2a53adb

3 years ago

rebased onto 0b192f3772955de4c8e0c2856ba1ab0cc6a790a0

3 years ago

@appadeia can you squash your commits here down to one? git rebase -i and a git push --force should do it?

done

Still -1 from me, includes more than just removing deprecated/kde4 stuff (adds falkon)

rebased onto c9834771c34b506ba78b6a8b61dc678aa2edb2db

3 years ago

Better now, thanks. +1, please merge

rebased onto be283daa471fc6c6bad02365c9e81b82a899244d

3 years ago

Better now, thanks. +1, please merge

Doesn't look like I have commit rights.

rebased onto 72009e3

3 years ago

Pull-Request has been merged by humaton

3 years ago
Metadata