PR#358: Fix f28 ansible node group and remove group in rawhide. - fedora-comps

fedora-comps

#358 Fix f28 ansible node group and remove group in rawhide.

Closed 4 years ago by sgallagh. Opened 5 years ago by kevin.

Unknown source ansible-node into master

Fix f28 ansible node group and remove group in rawhide.

Kevin Fenzi • 5 years ago

3e3edab

comps-f28.xml.in

file modified

+1 -1

		`@@ -112,7 +112,7 @@`
		`<uservisible>true</uservisible>`
		`<packagelist>`
		`<packagereq type="mandatory">python2-dnf</packagereq>`
		`- <packagereq type="conditional" requires="selinux-policy">libselinux-python</packagereq>`
		`+ <packagereq type="conditional" requires="selinux-policy">python2-libselinux</packagereq>`
		`</packagelist>`
		`</group>`
		`<group>`

comps-f30.xml.in

file modified

-11

		`@@ -106,17 +106,6 @@`
		`</packagelist>`
		`</group>`
		`<group>`
		`- <id>ansible-node</id>`
		`- <_name>Ansible node</_name>`
		`- <_description>This group contains packages necessary for the system to be controlled by Ansible.</_description>`
		`- <default>false</default>`
		`- <uservisible>true</uservisible>`
		`- <packagelist>`
		`- <packagereq type="mandatory">python2-dnf</packagereq>`
		`- <packagereq type="conditional" requires="selinux-policy">python2-libselinux</packagereq>`
		`- </packagelist>`
		`- </group>`
		`- <group>`
		`<id>arabic-support</id>`
		`<_name>Arabic Support</_name>`
		`<_description/>`

kevin commented 5 years ago

In f28 apparently libselinux changed also to use python2-libselinux
subpackage. (f29 was already updated to this).

In rawhide (f30) there no longer is a python2-dnf package, so remove
the group entirely as its no longer useful.

Signed-off-by: Kevin Fenzi kevin@scrye.com

sgallagh commented 5 years ago

      In f28 apparently libselinux changed also to use python2-libselinux
subpackage. (f29 was already updated to this).

Ack

In rawhide (f30) there no longer is a python2-dnf package, so remove
the group entirely as its no longer useful.

That doesn't sound right. We definitely still want an ansible-node group (or we need to figure out if whatever Ansible needs can be installed by default at least on Server). @maxamillion I know you were doing some work in this space not long ago; can you help us figure out what belongs in the ansible-node group for F30+ to make sure that Ansible can talk to the system?

kevin commented 5 years ago

Since there is no longer a python2-dnf, it needs to use python3 for talking to f30+ machines, but I know of no way to set that via comps. ansible upstream is going to try and have some autodetection in an upcoming release, which should help this. I don't see what the comps group could meaningfully do in f30+.

sgallagh commented 5 years ago

Since there is no longer a python2-dnf, it needs to use python3 for talking to f30+ machines, but I know of no way to set that via comps. ansible upstream is going to try and have some autodetection in an upcoming release, which should help this. I don't see what the comps group could meaningfully do in f30+.

Well, at minimum we need to make sure that it installs whatever packages will allow that autodetection to work properly. Which is why I pinged @maxamillion .