PR#282: workstation: Remove wvdial by default - fedora-comps

fedora-comps

#282 workstation: Remove wvdial by default

Merged 5 years ago by kevin. Opened 5 years ago by walters.

walters/fedora-comps nuke-wvdial into master

workstation: Remove wvdial by default

Colin Walters • 5 years ago

e2286d4

comps-f29.xml.in

file modified

-2

		`@@ -6545,7 +6545,6 @@`
		`<packagereq>pinfo</packagereq>`
		`<packagereq>plymouth</packagereq>`
		`<packagereq>polkit</packagereq>`
		`- <packagereq>ppp</packagereq>`
		`<packagereq>psacct</packagereq>`
		`<packagereq>qgnomeplatform</packagereq>`
		`<packagereq>qt</packagereq>`
		`@@ -6584,7 +6583,6 @@`
		`<packagereq>which</packagereq>`
		`<packagereq>wireless-tools</packagereq>`
		`<packagereq>words</packagereq>`
		`- <packagereq>wvdial</packagereq>`
		`<packagereq>xorg-x11-drv-libinput</packagereq>`
		`<packagereq>zip</packagereq>`
		`</packagelist>`

walters commented 5 years ago

It's the only thing pulling in compat-openssl10 which pulls in
make due to not having the commit to primary openssl in
https://src.fedoraproject.org/rpms/openssl/pull-request/1

And drop ppp as an explicit dependency, it's already pulled in
by other things such as NetworkManager-pptp; if we ever dropped
that we'd want ppp to go away too.

walters commented 5 years ago

This appears to have originated with the dial-up-support group from the very first commit here in git: https://pagure.io/fedora-comps/blob/c0622e777e0ec659b967619a94eeaf27632833d4/f/comps-f7.xml.in#_832

pbrobinson commented 5 years ago

You could probably drop wireless-tools, net-tools and a few others if you're looking at dropping legacy tools.

rebased onto 845cb91

5 years ago

rebased onto e2286d4

5 years ago

kevin commented 5 years ago

Commit 88d9069 fixes this pull-request

Pull-Request has been merged by kevin

5 years ago

Pull-Request has been merged by kevin

5 years ago

adamwill commented 5 years ago

Ironically (given the submitter) I think this actually broke Atomic Workstation builds, see e.g. https://koji.fedoraproject.org/koji/taskinfo?taskID=28585189:

DEBUG util.py:439:  error: No package matches 'wvdial'

now wvdial isn't in the Workstation tree, it's not there for the Atomic Workstation compose, which still wants to pull it in, because it's explicitly listed in fedora-workstation-base-pkgs.json.

So...we need a corresponding change there, to get FAW building again.

dustymabe commented 5 years ago

The problem is that the manifest needed to be updated after this was merged. the notification probably got lost because it mas merged a long time after the PR was opened.

This should get us moving in the right direction: https://pagure.io/workstation-ostree-config/pull-request/88

walters commented 5 years ago

https://pagure.io/workstation-ostree-config/pull-request/89