#235 Make core base-x packages mandatory
Closed 5 years ago by kevin. Opened 6 years ago by adamwill.
adamwill/fedora-comps basex-mandatory  into  master

file modified
+20 -20
@@ -353,26 +353,26 @@ 

      <default>false</default>

      <uservisible>false</uservisible>

      <packagelist>

-       <packagereq>glx-utils</packagereq>

-       <packagereq>mesa-dri-drivers</packagereq>

-       <packagereq>plymouth-system-theme</packagereq>

-       <packagereq>xorg-x11-drv-armsoc</packagereq>

-       <packagereq>xorg-x11-drv-ati</packagereq>

-       <packagereq>xorg-x11-drv-evdev</packagereq>

-       <packagereq>xorg-x11-drv-fbdev</packagereq>

-       <packagereq>xorg-x11-drv-intel</packagereq>

-       <packagereq>xorg-x11-drv-libinput</packagereq>

-       <packagereq>xorg-x11-drv-nouveau</packagereq>

-       <packagereq>xorg-x11-drv-omap</packagereq>

-       <packagereq>xorg-x11-drv-openchrome</packagereq>

-       <packagereq>xorg-x11-drv-qxl</packagereq>

-       <packagereq>xorg-x11-drv-vesa</packagereq>

-       <packagereq>xorg-x11-drv-vmware</packagereq>

-       <packagereq>xorg-x11-drv-wacom</packagereq>

-       <packagereq>xorg-x11-server-Xorg</packagereq>

-       <packagereq>xorg-x11-utils</packagereq>

-       <packagereq>xorg-x11-xauth</packagereq>

-       <packagereq>xorg-x11-xinit</packagereq>

+       <packagereq type="default">glx-utils</packagereq>

+       <packagereq type="mandatory">mesa-dri-drivers</packagereq>

+       <packagereq type="default">plymouth-system-theme</packagereq>

+       <packagereq type="default" arch="aarch64,armhfp">xorg-x11-drv-armsoc</packagereq>

+       <packagereq type="default" arch="i686,ppc64,ppc64le,x86_64">xorg-x11-drv-ati</packagereq>

+       <packagereq type="default" arch="aarch64,armhfp,i386,ppc64,ppc64le,x86_64">xorg-x11-drv-evdev</packagereq>

+       <packagereq type="default" arch="aarch64,armhfp,i386,ppc64,ppc64le,x86_64">xorg-x11-drv-fbdev</packagereq>

+       <packagereq type="default" arch="i386,x86_64">xorg-x11-drv-intel</packagereq>

+       <packagereq type="mandatory" arch="aarch64,armhfp,i386,ppc64,ppc64le,x86_64">xorg-x11-drv-libinput</packagereq>

+       <packagereq type="default" arch="aarch64,armhfp,i386,ppc64,ppc64le,x86_64">xorg-x11-drv-nouveau</packagereq>

+       <packagereq type="default" arch="armhfp">xorg-x11-drv-omap</packagereq>

+       <packagereq type="default" arch="i386,x86_64">xorg-x11-drv-openchrome</packagereq>

+       <packagereq type="default" arch="aarch64,armhfp,i386,ppc64,ppc64le,x86_64">xorg-x11-drv-qxl</packagereq>

+       <packagereq type="default" arch="i386,x86_64">xorg-x11-drv-vesa</packagereq>

+       <packagereq type="default" arch="i386,x86_64">xorg-x11-drv-vmware</packagereq>

+       <packagereq type="default" arch="aarch64,armhfp,i386,ppc64,ppc64le,x86_64">xorg-x11-drv-wacom</packagereq>

+       <packagereq type="mandatory">xorg-x11-server-Xorg</packagereq>

+       <packagereq type="mandatory">xorg-x11-utils</packagereq>

+       <packagereq type="mandatory">xorg-x11-xauth</packagereq>

+       <packagereq type="mandatory">xorg-x11-xinit</packagereq>

        <packagereq type="optional">xorg-x11-drv-geode</packagereq>

      </packagelist>

    </group>

This makes core base-x packages mandatory. That means the group
will not be considered to be 'installed' if they are removed, and
importantly, image composes will fail (as opposed to 'succeeding',
but with the packages left out) if they are missing or not
installable. That's the main benefit here.

In a way I'd like the core drivers to have been mandatory, but
for use by actual users on an installed system, we should still
consider the group installed if e.g. nouveau or intel aren't
present, I guess, as the user may want to remove drivers that
aren't related to the hardware they own.

Signed-off-by: Adam Williamson awilliam@redhat.com

rebased onto 689dc3d4c9e3887d985be9b81c7b3585829ede85

6 years ago

rebased onto adda464ee6516c1129b177413e81e69bcf1c6286

6 years ago

rebased onto 68515c4

6 years ago

I don't believe that the arch option works as you think it does. Unless dnf did something unexpected @dmach can you comment on dnf's behaviour here please

If 'arch' is supported by DNF, then it's something new to me.
To my understanding, comps support setting 'arch' option as part of input comps that is filtered in composes according to arch/basearch (I don't remember exactly).
I'll ask if anyone in the DNF team knows more details...

Any news here? @adamwill can you rebase and we can just give it a try?

Only query I would have is as we move to Wayland whether all the Xorg bits need to be mandatory, but overall if can have it rebased it can be adjusted moving forward

Pull-Request has been closed by kevin

5 years ago
Metadata