#238 Incorporate Fedmenu overlay on all pages for Local Development
Merged 4 years ago by jflory7. Opened 4 years ago by alishapapun.
fedora-commops/ alishapapun/fedora-happiness-packets fedmenu  into  master

file modified
+4 -1
@@ -404,4 +404,7 @@ 

  }

  .alert-danger ul {

      list-style: none;

- } 

\ No newline at end of file

+ }

+ .fedmenu-content {

+     position: absolute !important;

+ }

file modified
+9
@@ -115,6 +115,15 @@ 

                  </div>

                </small>

              </footer>

+             <script src="https://apps.fedoraproject.org/fedmenu/js/fedora-libravatar.js"></script>

+             <script src="https://apps.fedoraproject.org/fedmenu/js/fedmenu.js"></script>

+             <script>

+               fedmenu({

+                   'url': 'https://apps.fedoraproject.org/js/data.js',

+                   'mimeType': 'application/javascript',

+                   'position': 'bottom-right'

+               });

+             </script>

          </main>

      </body>

  </html>

Metadata Update from @jflory7:
- Pull-request tagged with: PASSED, needs testing, new change, type - frontend, type - summer coding

4 years ago

Hi @alishapapun! Thanks for working on this. :thumbsup:

This looks good, although I cannot see all of the sections of the menu. Is this an upstream bug or can we make fedmenu more responsive? For example, when I open the menu, I can't scroll down on my screen:

Screenshot of fedmenu flowing off-screen

Are you able to replicate this on smaller display sizes? (Btw, Responsive Design Mode in Firefox Web Dev Tools is useful for this!)

Metadata Update from @jflory7:
- Pull-request untagged with: needs testing
- Pull-request tagged with: needs changes
- Request assigned

4 years ago

1 new commit added

  • Fix bug
4 years ago

@jflory7, actually I had a look on the bug. The position property in custom.css for the position: absolute is not getting overwritten by the property in fedmenu.css. So, I tried to fix it at my end by declaring it as !important and it works as expected. Could you check it?

rebased onto a5eaa4e

4 years ago

Metadata Update from @jflory7:
- Pull-request untagged with: needs changes

4 years ago

@alishapapun Awesomeeee! :raised_hands: Works as expected on my laptop now. It doesn't look fantastic on mobile devices, but it works (I think this is an upstream issue with fedmenu anyways).

Thanks for getting this done. Merging! :ocean:

Pull-Request has been merged by jflory7

4 years ago