fedora-commops / fedora-happiness-packets

#236 Make admin portal easier to discover
Merged by jflory7. Opened by alishapapun.
fedora-commops/ alishapapun/fedora-happiness-packets experiment  into  master

Download 236.patch

This PR address #207 and needs some debugging and walkthrough. @shraddhaag could you have a look?

The current setup:
* If the user is superuser => only Admin Portal list item is available to the user. My Received Packets and My Sent Packets are not available.
* If the user is not a superuser => My Received Packets and My Sent Packets list items available.
Expected Setup:
* If the user is superuser => All three option, My Received Packets, My Sent Packets and Admin Portal must be available.
* If the user is not a superuser => My Received Packets and My Sent Packets list items available.

We need to only check if the user is a superuser for the Admin Portal option. So this conditional can be moved at the bottom after the other two list items such that those are always available to the user.

admin:index works without including admin_urls. You can remove this :)

@alishapapun awesome work :raised_hands:
The PR looks good to me. It just needs a couple minor changes I mentioned inline.
Let me know if the comments make sense :)

I almost forgot about this. The number of times I have forgotten this obscure URL is too often. :stuck_out_tongue_closed_eyes:

Metadata Update from @jflory7:
- Pull-request tagged with: PASSED, improvement, needs changes, type - frontend, type - summer coding
- Request assigned

@alishapapun Looking good! :thumbsup: Thanks @shraddhaag for jumping on this review. :raised_hands:

1 new commit added

  • Fix bugs

rebased onto ecc92f55d1e77ece878e7e4435eef5f434de72e6

@shraddhaag Hope this PR is perfect to get merged?

@shraddhaag Hope this PR is perfect to get merged?

Definitely! Looks good to me, I'm +1 for merging.

Edited by shraddhaag

Metadata Update from @jflory7:
- Pull-request untagged with: needs changes

Looks good to me too. Thanks @alishapapun!

Merging. :ocean:

Pull-Request has been merged by jflory7
Metadata
shraddhaag

PASSED improvement type - frontend type - summer coding

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.