#2 New attribute "result"
Merged 5 years ago by psss. Opened 5 years ago by psss.

file added
+28
@@ -0,0 +1,28 @@ 

+ name: result

+ type: string

+ purpose: specify how test result should be interpreted

+ 

+ motivation:

+     Even if a test fails it might makes sense to execute it to be able

+     to manually review the results (ignore test result) or ensure the

+     behaviour has not unexpectedly changed and the test is still failing

+     (expected fail).

+ 

+ stories:

+     - As a developer I have a test, I know it's failing for now, yet I

+       want to have it for future reference.

+     - As a tester I want to regularly execute the test but temporarily

+       ignore test result until more investigation is done and the test

+       can be fixed properly.

+ 

+ notes:

+     The following values should be supported:

+     - respect: test result is respected (fails when test failed)

+     - ignore: ignore the test result (test always passes)

+     - xfail: expected fail (pass when test fails, fail when test passes)

+ 

+ examples: |

+     result: ignore

+ 

+ notes:

+     The default value is: "result: respect".

As discussed on the Best Practices meeting, this pull request is proposing a new attribute to handle different ways how to interpret test results. I am not completely sure about the attribute name result. Does anyone have a suggestion for a better name?

rebased onto 2b2c6ed

5 years ago

Added default value. @plautrba, thanks for the idea.

Hmm, I thought this is expected fail. Maybe we need a better name?

Hmm, I thought this is expected fail. Maybe we need a better name?

imho name is fine (although I would prefer 'expfail'), however the description is confusing.

'make sure the test fails' sound to me like this attribute somehow makes the test fail.

right! we need a better description like: expect test to fail here. I.e. Fail will be perceived as pass, pass as a failure.

Yes, xfail should be expected fail. Let's try to find a better description:

xfail: expected fail (pass when test failed, fail when test passed)

@mvadkert, @jheger, does that sound better now? Any wording suggestions?

1 new commit added

  • Update description for expected fail
5 years ago

Metadata Update from @psss:
- Request assigned

5 years ago

OK, description updated.

Pull-Request has been merged by psss

5 years ago

Metadata Update from @psss:
- Pull-request tagged with: test metadata

5 years ago
Metadata
Changes Summary 1