#96 Add new artifact type: redhat-advisory
Merged 4 years ago by mvadkert. Opened 4 years ago by ralph.

@@ -0,0 +1,32 @@ 

+ {

+     "pipeline": {

+         "id": "ac11dcddf99a",

+         "name": "ci-job"

+     },

+     "run": {

CAT team is using (beside test logs) also html reports of a test. A field for it would be convenient (e.g. "report": "https://some-report.html").

+         "url": "https://example.redhat.com/tests/583271",

+         "id": 583271,

+         "log": "https://example.redhat.com/tests/583271/file/stdout.txt"

+     },

+     "version": "0.2.6",

+     "system": [],

+     "artifact": {

+         "type": "redhat-advisory",

+         "id": "RHBA-2017:01234-03"

+     },

+     "contact": {

+         "name": "Fictional Content Compressibility Test Team Jenkins (FCCTT)",

+         "url": "https://example.redhat.com",

+         "docs": "https://example.redhat.com/wiki/FCCTT",

+         "team": "Fictional Content Compressibility Testing Team",

+         "irc": "#fcctt-team-is-the-best",

+         "email": "fcctt-team@redhat.com"

+     },

+     "test": {

+         "category": "validation",

+         "type": "compression",

+         "namespace": "fcctt",

+         "result": "passed"

+     },

+     "generated_at": "2020-02-24T16:40:18Z"

+ }

@@ -0,0 +1,34 @@ 

+ {

+     "pipeline": {

+         "id": "ac11dcddf99a",

+         "name": "ci-job"

+     },

+     "run": {

+         "url": "https://example.redhat.com/tests/583271",

+         "id": 583271,

+         "log": "https://example.redhat.com/tests/583271/file/stdout.txt"

+     },

+     "version": "0.2.6",

+     "system": [],

+     "artifact": {

+         "type": "redhat-advisory",

+         "id": "RHBA-2017:01234-03"

+     },

+     "contact": {

+         "name": "Fictional Content Compressibility Test Team Jenkins (FCCTT)",

+         "url": "https://example.redhat.com",

+         "docs": "https://example.redhat.com/wiki/FCCTT",

+         "team": "Fictional Content Compressibility Testing Team",

+         "irc": "#fcctt-team-is-the-best",

+         "email": "fcctt-team@redhat.com"

+     },

+     "error": {

+         "reason": "content is not adequately compressible"

+     },

+     "test": {

+         "category": "validation",

+         "type": "compression",

+         "namespace": "fcctt"

+     },

+     "generated_at": "2020-02-24T16:40:18Z"

+ }

@@ -0,0 +1,32 @@ 

+ {

+     "pipeline": {

+         "id": "ac11dcddf99a",

+         "name": "ci-job"

+     },

+     "run": {

+         "url": "https://example.redhat.com/tests/583271",

+         "id": 583271,

+         "log": "https://example.redhat.com/tests/583271/file/stdout.txt"

+     },

+     "version": "0.2.6",

+     "system": [],

+     "artifact": {

+         "type": "redhat-advisory",

+         "id": "RHBA-2017:01234-03"

+     },

+     "contact": {

+         "name": "Fictional Content Compressibility Test Team Jenkins (FCCTT)",

+         "url": "https://example.redhat.com",

+         "docs": "https://example.redhat.com/wiki/FCCTT",

+         "team": "Fictional Content Compressibility Testing Team",

+         "irc": "#fcctt-team-is-the-best",

+         "email": "fcctt-team@redhat.com"

+     },

+     "test": {

+         "category": "validation",

+         "type": "compression",

+         "namespace": "fcctt",

+         "lifetime": 240

+     },

+     "generated_at": "2020-02-24T16:40:18Z"

+ }

@@ -0,0 +1,32 @@ 

+ {

+     "pipeline": {

+         "id": "ac11dcddf99a",

+         "name": "ci-job"

+     },

+     "run": {

+         "url": "https://example.redhat.com/tests/583271",

+         "id": 583271,

+         "log": "https://example.redhat.com/tests/583271/file/stdout.txt"

+     },

+     "version": "0.2.6",

+     "system": [],

+     "artifact": {

+         "type": "redhat-advisory",

+         "id": "RHBA-2017:01234-03"

+     },

+     "contact": {

+         "name": "Fictional Content Compressibility Test Team Jenkins (FCCTT)",

+         "url": "https://example.redhat.com",

+         "docs": "https://example.redhat.com/wiki/FCCTT",

+         "team": "Fictional Content Compressibility Testing Team",

+         "irc": "#fcctt-team-is-the-best",

+         "email": "fcctt-team@redhat.com"

+     },

+     "test": {

+         "category": "validation",

+         "type": "compression",

+         "namespace": "fcctt",

+         "lifetime": 240

+     },

+     "generated_at": "2020-02-24T16:40:18Z"

+ }

file modified
+2 -2
@@ -26,9 +26,9 @@ 

      version:

          description:

              Version of the specification. Following semantic versioning

-             (https://semver.org/). Current version is 0.2.5.

+             (https://semver.org/). Current version is 0.2.6.

          examples:

-             - 0.2.5

+             - 0.2.6

          type: string

  

  type: object

@@ -0,0 +1,42 @@ 

+ $id: redhat-advisory.test.complete

+ $schema: http://json-schema.org/draft-07/schema#

+ 

+ description:

+     Testing of the advisory has been completed.

+     This is a mandatory message.

+ 

+ properties:

+     contact:

+         $ref: contact.json

+     run:

+         $ref: run.json

+     artifact:

+         $ref: redhat-advisory.json

+     pipeline:

+         $ref: pipeline.json

+     test:

+         allOf:

+           - $ref: test-common.json

+           - $ref: test-complete.json

+     notification:

+         $ref: notification.json

+     system:

+         type: array

+         items:

+             $ref: system.json

+     generated_at:

+         $ref: common.json#properties/generated_at

+     version:

+         $ref: common.json#properties/version

+ 

+ required:

+     - contact

+     - run

+     - artifact

+     - pipeline

+     - test

+     - system

+     - generated_at

+     - version

+ 

+ type: object

@@ -0,0 +1,40 @@ 

+ $id: redhat-advisory.test.error

+ $schema: http://json-schema.org/draft-07/schema#

+ 

+ description:

+     Testing has aborted, it was not finished, e.g. because of infrastructure

+     error, CI system error, etc. Note that a test failure is not an error.

+     Test failures should be exposed under the redhat-advisory.test.complete

+     topic. This is a mandatory message.

+ 

+ properties:

+     contact:

+         $ref: contact.json

+     run:

+         $ref: run.json

+     artifact:

+         $ref: redhat-advisory.json

+     pipeline:

+         $ref: pipeline.json

+     test:

+         $ref: test-common.json

+     error:

+         $ref: error.json

+     notification:

+         $ref: notification.json

+     generated_at:

+         $ref: common.json#properties/generated_at

+     version:

+         $ref: common.json#properties/version

+ 

+ required:

+     - contact

+     - run

+     - artifact

+     - pipeline

+     - test

+     - error

+     - generated_at

+     - version

+ 

+ type: object

@@ -0,0 +1,33 @@ 

+ $id: redhat-advisory.test.queued

+ $schema: http://json-schema.org/draft-07/schema#

+ 

+ description:

+     Testing has been queued, but not started yet.

+     This is an optional message.

+ 

+ properties:

+     contact:

+         $ref: contact.json

+     run:

+         $ref: run.json

+     artifact:

+         $ref: redhat-advisory.json

+     pipeline:

+         $ref: pipeline.json

+     test:

+         $ref: test-common.json

+     generated_at:

+         $ref: common.json#properties/generated_at

+     version:

+         $ref: common.json#properties/version

+ 

+ required:

+     - contact

+     - run

+     - artifact

+     - pipeline

+     - test

+     - generated_at

+     - version

+ 

+ type: object

@@ -0,0 +1,33 @@ 

+ $id: redhat-advisory.test.running

+ $schema: http://json-schema.org/draft-07/schema#

+ 

+ description:

+     Testing has been started and is in progress.

+     This is an optional message.

+ 

+ properties:

+     contact:

+         $ref: contact.json

+     run:

+         $ref: run.json

+     artifact:

+         $ref: redhat-advisory.json

+     pipeline:

+         $ref: pipeline.json

+     test:

+         $ref: test-common.json

+     generated_at:

+         $ref: common.json#properties/generated_at

+     version:

+         $ref: common.json#properties/version

+ 

+ required:

+     - contact

+     - run

+     - artifact

+     - pipeline

+     - test

+     - generated_at

+     - version

+ 

+ type: object

@@ -0,0 +1,33 @@ 

+ $id: redhat-advisory

+ $schema: http://json-schema.org/draft-07/schema#

+ 

+ description:

+     Details about the Red Hat advisory being tested.

+ 

+ properties:

+     type:

+         description:

+             Artifact type, in this case 'redhat-advisory'.

+         enum:

+             - redhat-advisory

+         type: string

+     id:

+         description:

+             Full alias of the advisory as provided by the errata system, including type, year, and respin counter.

+         examples:

+             - RHBA-2017:01234-03

+         type: string

+     numeric_id:

+         description:

+             An integer identifier for the advisory.

+         examples:

+             - 51257

+         type: integer

+ 

+ required:

+     - type

+     - id

+     # Not required.

+     #- numeric_id

+ 

+ type: object

This is analogous to the entity we already have for fedora-updates,
but applied to Red Hat errata (a.k.a. "advisories").

rebased onto 28a8c4d1884da6e7295d35b33012d8156f60ede3

4 years ago

Metadata Update from @mvadkert:
- Pull-request tagged with: review-needed

4 years ago

@ralph seems the current version is 0.2.5, can we make this 0.2.6 and update also the current version in common.yaml pls? https://pagure.io/fedora-ci/messages/blob/master/f/schemas/common.yaml#_31

@msrb @odockal @awilliam hey guys, would you have time also to review pls?

@ralph just a small nitpick, I did not find anything else, looks very nice addition to me

so :thumbsup: from me

1 new commit added

  • Update version to 0.2.6 for addition of redhat-advisory
4 years ago

Shouldn't be there redhat-advisory.test.running.json file also?

nice catch, even though it is optional, would be nice to add it for consistency

@mvadkert No build and promote event? If not, then is seems ok. +1. If upversioning to 0.2.6, we should upversion every example, shouldn't we?

@odockal I do not think that is important to upversion each example. The version in example should indicate the minimal version where this works ...

CAT team is using (beside test logs) also html reports of a test. A field for it would be convenient (e.g. "report": "https://some-report.html").

@jbijota we already have this filed for that I believe:

https://pagure.io/fedora-ci/messages/blob/master/f/schemas/run.yaml#_15

Can you use just that maybe?

I would like to avoid adding additional fields if not really needed

@jbijota we already have this filed for that I believe:
https://pagure.io/fedora-ci/messages/blob/master/f/schemas/run.yaml#_15
Can you use just that maybe?

Yeah, definitely! Thanks for the info.

1 new commit added

  • Add running example for redhat-advisory.test
4 years ago

Adding example of redhat-advisory.test.running.

Ok, seems no more comments and all issues seems addressed.

Promote events can be added later if needed.

Metadata Update from @mvadkert:
- Pull-request untagged with: review-needed
- Pull-request tagged with: review-done

4 years ago

rebased onto 15c94a4

4 years ago

Pull-Request has been merged by mvadkert

4 years ago