#97 invalid compose_type examples in productmd-compose
Closed 3 years ago by lsedlar. Opened 4 years ago by lsedlar.

The schema for productmd-compose shows example for compose_type value as rel-eng, nightly, testing, updates, released

Productmd defines valid compose types as test, ci, nightly and production.
https://productmd.readthedocs.io/en/latest/composeinfo.html#productmd.composeinfo.COMPOSE_TYPES

It seems to me the examples are mixing compose types with release types:
https://productmd.readthedocs.io/en/latest/common.html#productmd.common.RELEASE_TYPES

How is this value used? Where does it come from?


Looking at original commit 8ba6fb2.

Maybe @pholica can explain where the values come from?

I wasn't aware the values are from some specific already defined structure. The reason why I've put those values there was because that's how they are used by our team and other stakeholders.

The reason why they are mixed may be also as a mean to be able to efficiently trigger testing and find the location of the compose as the locations may differ based on the RELEASE_TYPE. It would be probably better to introduce the RELEASE_TYPE field to the message too.

Ok, I opened #99 to add the missing field.

@lsedlar is this issue resolved by #99?

Metadata Update from @lsedlar:
- Issue status updated to: Closed (was: Open)

3 years ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #99 Merged 3 years ago