#74 Validation fails without explanation
Closed 4 years ago by ralph. Opened 4 years ago by preichl.

Validator helped me to fix the message format I was working on with helpful messages, however at one moment it just stopped to show explanation message. Same happens when I try to validate the provided example.

./scripts/validate.py tmp/container-image.gate.complete.json examples/container-image.gate.complete.json
Validation failed.

The failure is because of #67 . It's silent because the validate script assumes any exception that occurs during validation will be explained by doing validator.iter_errors(load(path)), but...this case isn't. You can see the actual problem by just replacing the raise SystemExit(1) at the end of validate.py with a simple Raise to get at the original exception:

Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/jsonschema/validators.py", line 739, in resolve_from_url
    document = self.store[url]
  File "/usr/lib/python3.7/site-packages/jsonschema/_utils.py", line 23, in __getitem__
    return self.store[self.normalize(uri)]
KeyError: 'https://pagure.io/fedora-ci/messages/contact.json'

Should be closed with #75.

Metadata Update from @ralph:
- Issue status updated to: Closed (was: Open)

4 years ago

well...arguably there's still a bug here in that no error was shown in this case.

Login to comment on this ticket.

Metadata