#1 Improve pull request test results wording
Closed 2 years ago by mvadkert. Opened 5 years ago by psss.

Currently the results of a finished pull request pipeline job look like this:

All packages PR
Package tests: failed

From a developer point of view it does not make sense to call it "All packages PR". It should rather say something like "Standard Test Interface" or "Standard Fedora CI" or "Fedora CI". Also a commit hash should be displayed (as it does simple-koji-ci) to make it clear what was tested:

Fedora CI
Package tests failed for d780a93.

Example pull request:

Issue based on the feedback from @churchyard.


Should be linked somehow with ci description from the message format
https://pagure.io/fedora-ci/messages/blob/master/f/schemas/ci.yaml#_10

Changing to Fedora CI is easy: https://pagure.io/Fedora-Infra/loopabull-tasks/c/7672be42f3043227b6b5cb1dcbecf522e41a62ce adding the commit less so since the current messages don't have this info easily accessible: https://apps.fedoraproject.org/datagrepper/id?id=2018-07b98b50-3330-4534-893d-00f4bfc1d496&is_raw=true&size=extra-large (could be extracted from the nvr field but :s)

Metadata Update from @bookwar:
- Issue tagged with: UX

5 years ago

Metadata Update from @psss:
- Issue priority set to: High

5 years ago

With simple-koji-ci I can clearly see what was what, yet all new Fedora CI results override the old ones (they should IMHO only override the ones done on the same commit):

png

Uh Uh :) this was a feature with which we tried to solve the problem of need to have a ref to the commit id :) Sorry this was discussed in https://pagure.io/fedora-ci/general/issue/3 .. maybe it was not clear.

So you are saying we should roll that back and have it the same as simple-koji-ci?

Note that this year also CI Dashboard [1] is coming to Fedora, that could show also the older results. Would that be sufficient? I.e. have a separate web ui to show the test results linked from here?

[1] https://url.corp.redhat.com/ci-dashboard (note PRs are not yet displayed there)

It might be helpful to have a way of seeing old test results. I don't really care if they are all visible on the PR page or linked from there, but the need to go to a separate service that I need to know of (and remember) in order to see this is kinda weird.

@psss what is the current status on this? I feel like this may have predated some work we've done and it can be closed, but if there's some actions to take, let's itemize those so we can work on them and close this out :)

@jimbair yep, closing this. A lot of things have changed since then, results are tied now to commits and we are going forward with Zuul a lot. I believe this issue is now outdated.

Metadata Update from @mvadkert:
- Issue status updated to: Closed (was: Open)

2 years ago

Login to comment on this ticket.

Metadata
Attachments 1
png
Attached 5 years ago View Comment