PR#676: The pkgdb rules are not working anymore. - fedora-badges

fedora-badges

#676 The pkgdb rules are not working anymore.

Merged 3 years ago by jflory7. Opened 3 years ago by cverna.

cverna/fedora-badges remove_pkdb_badge into master

The pkgdb rules are not working anymore.

Clement Verna • 3 years ago

c916b49

retired_rules/helping-hand.yml ~~rules/helping-hand.yml~~

file renamed

file was moved with no change to the file

retired_rules/pkgdb-hatchling-i.yml ~~rules/pkgdb-hatchling-i.yml~~

file renamed

file was moved with no change to the file

retired_rules/pkgdb-old-yeller.yml ~~rules/pkgdb-old-yeller.yml~~

file renamed

file was moved with no change to the file

retired_rules/pkgdb-partners-in-crime.yml ~~rules/pkgdb-partners-in-crime.yml~~

file renamed

file was moved with no change to the file

retired_rules/pkgdb-phoenix-down.yml ~~rules/pkgdb-phoenix-down.yml~~

file renamed

file was moved with no change to the file

retired_rules/pkgdb-the-cat-came-back.yml ~~rules/pkgdb-the-cat-came-back.yml~~

file renamed

file was moved with no change to the file

cverna commented 3 years ago

This commit move the rules using pkdb to a retired_rules
directory. That way we do not sync them on the backend
server and break the fedmsg consumer.

Signed-off-by: Clement Verna cverna@tutanota.com

jflory7 commented 3 years ago

This makes sense and also explains the last few emails filtering through with fedmsg errors. Thanks for figuring this one and the last one out. It's cleaned up the signal-to-noise ratio for me significantly. :thumbsup: Merging.

An aside thought, I wish we had a better way to designate a Badge as "retired" in the web UI. I predict someone at some point will comment in one of these retired badges' original tickets and ask why they didn't receive it.

But for now, this is probably the best fix. The above could be a good requirement for an Outreachy internship.