In #535, the badge for ruby-sig members was created. However, looking at the award history and comparing to the sig members, the badge is not awarded. I wonder where is the problem. I thought it would work somehow automatically. Or maybe I just forgot some part of the process, dunno 🤔
Metadata Update from @gui1ty: - Issue assigned to gui1ty
It should be assigned automatically. But it looks like the badge was never added to the script that assigns these badges.
Metadata Update from @gui1ty: - Custom field artwork adjusted to None - Custom field concept_review_passed adjusted to None - Issue tagged with: D: easy, T: bug
Badges have been awarded during the last run of the script. The permanent fix is pending merge:
https://pagure.io/fedora-infra/ansible/pull-request/1325
Metadata Update from @gui1ty: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
Interestingly, there is 10 group members but just 9 awards. So something is still odd. But it it certainly better. Thx
Metadata Update from @vondruch: - Issue status updated to: Open (was: Closed)
I think that the users citizen428 and addisonmartin were not awarded.
Here's the log from the script:
processing ruby-sig ====================== athoscr@fedoraproject.org already has ruby-sig-member skipping. jaruga@fedoraproject.org already has ruby-sig-member skipping. valtri@fedoraproject.org already has ruby-sig-member skipping. vondruch@fedoraproject.org already has ruby-sig-member skipping. pvalena@fedoraproject.org already has ruby-sig-member skipping. awarding ruby-sig-member to snecker@fedoraproject.org awarding ruby-sig-member to jackorp@fedoraproject.org awarding ruby-sig-member to dkirwan@fedoraproject.org jaruga@fedoraproject.org already has ruby-sig-member skipping. vondruch@fedoraproject.org already has ruby-sig-member skipping. pvalena@fedoraproject.org already has ruby-sig-member skipping.
Users addisonmartin and citizen428 are indeed not mentioned. But they do not have an account in badges either. When I look at their profile pages, I get a 404. I assume that means they never logged in to badges.
I will need to check with some of the old folks on how account creation for badges works.
Interestingly, there is 10 group members but just 9 awards.
Keep in mind that people leaving the SIG will retain their badge. There's no mechanism of taking the badge from them. So, the number of badges awarded will not always match the number of members in the SIG.
Users addisonmartin and citizen428 are indeed not mentioned. But they do not have an account in badges either. When I look at their profile pages, I get a 404. I assume that means they never logged in to badges. I will need to check with some of the old folks on how account creation for badges works.
Interesting. Thank you for looking into this.
Interestingly, there is 10 group members but just 9 awards. Keep in mind that people leaving the SIG will retain their badge. There's no mechanism of taking the badge from them. So, the number of badges awarded will not always match the number of members in the SIG.
Right, but the number of badges awarded should always be >= number of SIG members. That was my rough way of identifying the issue.
Commit 732daf55 fixes this issue
@vondruch, regarding some users not being awarded the SIG badge, the consensus is that they haven't logged in to badges with their FAS account. Although, the exact mechanism for account creation remains a mystery. :tophat:
Metadata Update from @gui1ty: - Issue close_status updated to: None (was: Fixed)
Log in to comment on this ticket.