#892 Remove outdated discussion references in config yml
Opened 2 years ago by gui1ty. Modified a year ago

A few early day badges still contain references to discussion on Github.

Take the Curious Penguin series as an example:

Criteria: https://github.com/oddshocks/badges/blob/master/docs/badges.rst

This project is now redirecting to another project, which in turn has been archived.

Solution:

  • If there's an issue in Pagure with the rules explained (usually badge request) for the badge (series), update the rules yml file to point to that issue.
  • If we don't have an issue for the badge (series) in Pagure, point it to this ticket (the one you are reading now) or maybe to a landing page explaining the "problem" with the badge.

Badge meta data is stored in the database. Specifically, the criteria field needs to be updated as explained in https://pagure.io/fedora-badges/issue/892#comment-832644


Hi! Is this issue still open? If yes, can I work on it?

Sure. Thanks for your help. I'll assign to you.

Metadata Update from @gui1ty:
- Custom field artwork adjusted to None
- Custom field concept_review_passed adjusted to None
- Issue assigned to attreyeem

a year ago

Hi! I have been trying to look at the codebase and had a small question. I will find the page https://badges.fedoraproject.org/badge/curious-penguin-ask-fedora-i in a folder in this repo or in https://github.com/fedora-infra/tahrir? It seems like the code of the website is in https://github.com/fedora-infra/tahri. Is that correct? Or
Do I need to change the links like that for discussions in rules folder of this repository ?
If yes, where do I need to redirect those links to?

Tahrir is the frontend for badges, but the badges live in this repository on Pagure (https://pagure.io/fedora-badges/blob/master/f/rules). When new badges are added, the configuration files (backend) and images (frontend) are uploaded to the responsible machines. That process is described on https://docs.fedoraproject.org/en-US/badges/push-badges/

Thinking about it, and having stumbled upon some other issues, I'm not even sure that updating the rules files will actually change anything on the badges website. I will need to try that out on one badge first before you set out to updating them all.

Btw, if you are interested and have the time, there will be a badges meeting this week Thursday at 16:00 UTC. See https://discussion.fedoraproject.org/t/getting-fedora-badges-back-in-shape/42942/27 for more information and how to get invited.

@gui1ty Although I may not be able to fully solve this issue, but please let me know if I can be of any help in solving this.

Metadata Update from @attreyeem:
- Assignee reset

a year ago

No worries, @attreyeem. As I explained, I opened that ticket when I still not had a full picture of how badges work and how the different systems interact.

For the record: badge data is stored in a database once new badges have been added in the Tahrir backend. In order to remove/update the outdated links, the database entries have to be updated. That, of course, begs the question, why we store the same information in two different places.

The edit-badge script in /usr/local/bin on badges-backend01appers to be able to change the criteria entry for a badge. Something to look into, but not very urgent at the moment.

Metadata Update from @gui1ty:
- Issue untagged with: D: easy, good first issue
- Issue tagged with: C: miscellaneous, D: intermediate

a year ago

Login to comment on this ticket.

Metadata