Not working anymore. For example this badge should appear after 1 test in Bodhi, but it doesnt.
@bowlofeggs, could you maybe help use to update the rules? Assuming Bodhi 4 changed the messages somehow.
Metadata Update from @churchyard: - Custom field artwork adjusted to None - Custom field concept_review_passed adjusted to None
I suppose that anonymous comments are now handled differently, correct?
Heh, yeah this line looks suspicious to me:
https://pagure.io/fedora-badges/blob/master/f/rules/tester-01.yml#_26
There is no longer an anonymous attribute on comments, and that call to get() has a default of True if the anonymous key is missing. So it seems that it thinks all comments are anonymous?
anonymous
get()
True
You can assume that no comments are anonymous now, because we've dropped that feature.
So, tl;dr; I bet you can drop the .get('anonymous', True) and that might fix it.
.get('anonymous', True)
Actually, maybe you can just drop that entire line.
I think so, yes.
https://pagure.io/fedora-badges/pull-request/689
Metadata Update from @riecatnor: - Issue tagged with: bug
So, can this issue be closed ? The related PR got merged, no ?
@churchyard
Metadata Update from @jflory7: - Custom field triaged adjusted to on - Issue assigned to churchyard - Issue tagged with: category - quality
Provided the badge was last awarded today, I will close this as fixed:
https://badges.fedoraproject.org/badge/in-search-of-the-bull-tester-i
Metadata Update from @jflory7: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.