#97 post: Be rofiles-fuse compatible
Merged 4 years ago by jlebon. Opened 4 years ago by walters.
walters/fedora-atomic unified-core-post-compat  into  master

post: Be rofiles-fuse compatible
Colin Walters • 4 years ago  
file modified
+5 -1
@@ -3,4 +3,8 @@ 

  set -xeuo pipefail

  

  # Work around https://bugzilla.redhat.com/show_bug.cgi?id=1265295

- echo 'Storage=persistent' >> /etc/systemd/journald.conf

+ # Also note the create-new-then-rename dance for rofiles-fuse compat

+ if ! grep -q '^Storage=persistent' /etc/systemd/journald.conf; then

+     (cat /etc/systemd/journald.conf && echo 'Storage=persistent') > /etc/systemd.journald.conf.new

+     mv /etc/systemd.journald.conf{.new,}

+ fi

This fixes corruption I saw when using unified core 🌐 mode; we
ended up appending repeatedly to the version in the imported
pkgcache repo.

this mostly LGTM.

I do have some concern, though. We obviously manage the treecompose-post.sh file ourselves and we can control what goes into it. What about people who are building/hosting their own ostrees. Are there certain rules they have to follow? i.e. can you elaborate on the problem a little more and explain why it is or is not a problem for others?

Pull-Request has been merged by jlebon

4 years ago
Metadata