179958d
@@ -88,7 +88,7 @@
"which",
"nfs-utils",
"curl",
- "iptables-services", "iptables",
+ "iptables-services", "iptables", "firewalld",
"NetworkManager",
"dnsmasq",
"hostname", "initscripts", "iproute", "iputils", "less",
@@ -18,3 +18,7 @@
ln -srf /usr/bin/true ${x}
fi
done
+
+ # Disable firewalld - we include it but don't want it enabled by default
+ # See https://pagure.io/atomic-wg/issue/372
+ systemctl disable firewalld
We want to include it to ease the lives of some ops guys/gals who want to use it and don't want to jump through hoops to get it.
See https://pagure.io/atomic-wg/issue/372
Can you briefly remind me the status of this - we were at one point going to use mask right? But that's not necessary anymore?
mask
Also worth adding a link here the WG issue I'd say (annotate will show it, but it's easy for code motion to require more hoops to get through annotate).
Not necessary, see https://pagure.io/fedora-lorax-templates/pull-request/25.. This does have the unfortunate side effect that people bringing their own kickstarts will need to add this line to them.
rebased onto 179958d
updated!
LGTM, will leave open a bit for anyone else to comment.
I'll wait til later in the day and probably try to merge tonight before the rawhide run starts.
Pull-Request has been merged by dustymabe
We want to include it to ease the lives of some ops guys/gals who want
to use it and don't want to jump through hoops to get it.
See https://pagure.io/atomic-wg/issue/372