PR#16: remove uneeded kernelcmdline args - fedora-asahi/kiwi-descriptions

fedora-asahi / kiwi-descriptions

#16 remove uneeded kernelcmdline args

Merged 11 months ago by ngompa. Opened 11 months ago by leifliddy.

Unknown source rawhide into rawhide

Leif Liddy • 11 months ago

1f96cd2

platforms/minimal.xml

file modified

+1 -1

		`@@ -6,7 +6,7 @@`
		`</profile>`
		`</profiles>`
		`<preferences profiles="Minimal">`
		`- <type image="oem" filesystem="btrfs" kernelcmdline="scsi_mod.use_blk_mq=1 multipath=off" target_blocksize="4096" bootpartition="true" bootpartsize="1000" bootfilesystem="ext4" efipartsize="500" firmware="uefi" fsmountoptions="x-systemd.growfs,compress=zstd:1">`
		`+ <type image="oem" filesystem="btrfs" kernelcmdline="" target_blocksize="4096" bootpartition="true" bootpartsize="1000" bootfilesystem="ext4" efipartsize="500" firmware="uefi" fsmountoptions="x-systemd.growfs,compress=zstd:1">`
		`<bootloader name="grub2" console="console" timeout="5" timeout_style="hidden"/>`
		`<systemdisk name="fedora">`
		`<volume name="home"/>`

platforms/server.xml

file modified

+1 -1

		`@@ -6,7 +6,7 @@`
		`</profile>`
		`</profiles>`
		`<preferences profiles="Server">`
		`- <type image="oem" filesystem="btrfs" kernelcmdline="scsi_mod.use_blk_mq=1 multipath=off" target_blocksize="4096" bootpartition="true" bootpartsize="1000" bootfilesystem="xfs" efipartsize="500" firmware="uefi" fsmountoptions="x-systemd.growfs,compress=zstd:1">`
		`+ <type image="oem" filesystem="btrfs" kernelcmdline="" target_blocksize="4096" bootpartition="true" bootpartsize="1000" bootfilesystem="xfs" efipartsize="500" firmware="uefi" fsmountoptions="x-systemd.growfs,compress=zstd:1">`
		`<bootloader name="grub2" console="console" timeout="5" timeout_style="hidden"/>`
		`<systemdisk name="fedora">`
		`<volume name="home"/>`

platforms/workstation.xml

file modified

+1 -1

		`@@ -14,7 +14,7 @@`
		`</profile>`
		`</profiles>`
		`<preferences profiles="WorkstationCommon">`
		`- <type image="oem" filesystem="btrfs" kernelcmdline="scsi_mod.use_blk_mq=1 multipath=off rhgb quiet" target_blocksize="4096" bootpartition="true" bootpartsize="1000" bootfilesystem="ext4" efipartsize="500" firmware="uefi" fsmountoptions="x-systemd.growfs,compress=zstd:1">`
		`+ <type image="oem" filesystem="btrfs" kernelcmdline="rhgb quiet" target_blocksize="4096" bootpartition="true" bootpartsize="1000" bootfilesystem="ext4" efipartsize="500" firmware="uefi" fsmountoptions="x-systemd.growfs,compress=zstd:1">`
		`<bootloader name="grub2" console="console" timeout="5" timeout_style="hidden"/>`
		`<systemdisk name="fedora">`
		`<volume name="home"/>`

leifliddy commented 11 months ago

remove the kernelcmdline args: scsi_mod.use_blk_mq=1 multipath=off
as they no longer required. I know F36 had an issue with multipath being enabled -- but that has since been resolved.
Not sure why scsi_mod.use_blk_mq=1 is set as the system boots fine without it.
I was mulling over whether to remove kernelcmdline entirely vs setting to a blank value....
Anyways, let me know what your thoughts are on this change.

dcavalca commented 11 months ago

multipath=off in only consumed by device-mapper-multipath, which isn't part of a default install, at least on Workstation. I can't find any references at all to scsi_mod.use_blk_mq=1 in Fedora -- @ngompa any idea where that one came from?