#27 Merge half hour slots of one long meeting
Closed: Fixed None Opened 7 years ago by lbrabec.

Meeting that is one hour long (or longer) is shown as several half hour meetings.

Version from git.fedorahosted.org


Oh sorry for the patch, I missed the notification. I'll try to review it asap!

Quickly looking at it, any reason to change the create_tables call on model.py?

I had problem with loading config (another version I presume) and this was the
change that helped me. I was playing with fedocal and made some other changes in code
when trying some stuff. I wanted to put away all such changes, so the patch contains
only relevant things. I overlooked this one, sorry for that.

Could you resubmit it without?

patch proposal (clean version)
ticket27.patch

Arg, not getting the email when an attachment is submitted is annoying!

I was starting to look into this but I noticed that you did not use git format-patch. I'll look at it using patch but if you could also attach a git format-patch generated patch that would be great! (that would also keep the provenance and attribution correct).

Thanks

Ok I have tried to do my own version of the patch, what do you think of this?

The idea being to reduce the changes in the controller and the css and avoid having fixed sizes and css in the html.

Seeing the work in progress, this should be ready for 0.2.0

I re-uploaded the file as the version I had was buggy when tested with meeting going over multiple days (timezone change and this kind of joy).

If you have time to look at it, let me know what you think :)

Login to comment on this ticket.

Metadata
Attachments 2
Attached 7 years ago View Comment
Attached 7 years ago View Comment