I think that we should create both F25 and already F26 RID. Opinions?
"fedora.25": { "#import": [ "fedora" ] }, "fedora.25-x64": { "#import": [ "fedora.25", "fedora-x64" ] }, "fedora.26": { "#import": [ "fedora" ] }, "fedora.26-x64": { "#import": [ "fedora.26", "fedora-x64" ] },
Metadata Update from @rhea: - Issue assigned to rhea - Issue tagged with: upstream
I agree, I'm already patching when building:
https://pagure.io/fedora-dotnet/blob/f25/f/dotnetcore-1.1-RIL-fix.patch
We should definitely try and get both F25 and F26. I think maybe even try to go for fedora-rawhide? Not sure how that one would be detected though.
fedora-rawhide
I would keep rawhide as separate PR either, if we do add it.
I do have one more question - should I include 25/26 here straight away? https://github.com/dotnet/corefx/blob/master/pkg/Microsoft.Private.CoreFx.NETCoreApp/Microsoft.Private.CoreFx.NETCoreApp.props#L42
And these: https://github.com/dotnet/corefx/blob/master/src/System.Security.Cryptography.X509Certificates/tests/ChainTests.cs#L15 https://github.com/dotnet/corefx/blob/master/src/Common/tests/System/PlatformDetection.cs#L71
What about this... https://github.com/dotnet/corefx/blob/master/init-tools.sh#L45
(I'm getting a feeling that i'm repeating myself.)
init-tools.sh and variants (bootstrap.sh, install-dotnet.sh) download a version of dotnet core that is then used to build the rest of .NET Core projects (such as corefx and coreclr). If we can build corefx without fixing this then we don't need to fix it at all.
init-tools.sh
bootstrap.sh
install-dotnet.sh
In fact, we probably want to avoid using init-tools.sh at all: we don't want to use a version of .NET Core that's downloaded to build everything; we want to use the version we supply (just built via rover in this case) to build everything.
https://github.com/dotnet/corefx/blob/master/src/System.Security.Cryptography.X509Certificates/tests/ChainTests.cs#L15 https://github.com/dotnet/corefx/blob/master/src/Common/tests/System/PlatformDetection.cs#L71
Tests, so they would be nice to fix, but not urgent.
https://github.com/dotnet/corefx/blob/master/pkg/Microsoft.Private.CoreFx.NETCoreApp/Microsoft.Private.CoreFx.NETCoreApp.props#L42
OfficialBuildRID... I wonder if this means upstream has to commit to supporting it for us to be able to add to it.
OfficialBuildRID
kay in that case i dont need to add moar, and i'll PR (i already have that stuff written) and if they complain i'll shove a cookie up their ... neck
...tomorrow, cause i got distracted a few hours ago and now it's super late for me!
Btw I think that the "official" build RID just refers to what Microsoft builds and releases on their website...
https://github.com/dotnet/corefx/pull/16302
Login to comment on this ticket.