PR#3: Update to .NET Core Runtime 2.1.2 and SDK 2.1.302 - dotnet-sig/dotnet-2-1

dotnet-sig / dotnet-2-1

#3 Update to .NET Core Runtime 2.1.2 and SDK 2.1.302

Merged 5 years ago by rhea. Opened 5 years ago by omajid.

dotnet-sig/ omajid/dotnet-2-1 master into master

Update to .NET Core Runtime 2.1.2 and SDK 2.1.302

Omair Majid • 5 years ago

64ff682

README.md

file modified

+2 -3

		`@@ -57,10 +57,9 @@`

		`5. Do local builds`

		- - `fedpkg --dist $YOUR_FEDORA_VERSION local`
		+ - `fedpkg local --builddir ../dotnet-2-1-build`

		`- Where the version can be, for example, f27. Fix any errors that`
		`- come up and rebuild until it works locally.`
		`+ Fix any errors that come up and rebuild until it works locally.`

		`6. Upload the new tarball to a public URL, if there is a new tarball.`
		`I use:`

dotnet.spec

file modified

+8 -5

		`@@ -12,12 +12,12 @@`
		`%global __provides_exclude ^(%{privlibs})\\.so`
		`%global __requires_exclude ^(%{privlibs})\\.so`

		`- %global sdk_version 2.1.301`
		`- %global runtime_version 2.1.1`
		`+ %global sdk_version 2.1.302`
		`+ %global runtime_version 2.1.2`

		`Name: dotnet`
		`Version: %{sdk_version}`
		`- Release: 2%{?dist}`
		`+ Release: 1%{?dist}`
aslice commented 5 years ago This went from 2%{?dist} to 1%{?dist}, is that number supposed to reset instead of increment?
		`Summary: .NET Core CLI tools and runtime`
		`License: MIT and ASL 2.0 and BSD`
		`URL: https://github.com/dotnet/`
		`@@ -29,7 +29,7 @@`
		`# - ./build-source-tarball.sh dotnet-%%{sdk_version}`
		`# - tar cvzf dotnet-%%{sdk_version}.tar.gz dotnet-%%{sdk_version}`

		`- Source0: https://omajid.fedorapeople.org/dotnet/dotnet-%{sdk_version}.tar.gz`
		`+ Source0: https://omajid.fedorapeople.org/dotnet/dotnet-%{runtime_version}.tar.gz`
		`Source1: check-debug-symbols.py`

		`ExclusiveArch: x86_64`
		`@@ -141,7 +141,7 @@`
		`applications and micro-services.`

		`%prep`
		`- %setup -q -n %{name}-%{sdk_version}`
		`+ %setup -q -n %{name}-%{runtime_version}`

		`# See https://github.com/dotnet/source-build/pull/669`
		`rm -rf Tools/configuration/configuration.props`
		`@@ -217,6 +217,9 @@`
		`%{_libdir}/%{name}/sdk/%{sdk_version}`

		`%changelog`
		`+ * Mon Aug 20 2018 Omair Majid <omajid@redhat.com> - 2.1.302-1`
		`+ - Update to .NET Core Runtime 2.1.2 and SDK 2.1.302`
		`+`
		`* Fri Jul 20 2018 Omair Majid <omajid@redhat.com> - 2.1.301-1`
		`- Update to .NET Core 2.1`

omajid commented 5 years ago

Build here: https://copr.fedorainfracloud.org/coprs/g/dotnet-sig/dotnet/build/789492/

I have actually run out of space on fedorapeople.org. So I am looking for alternative hosting locations. But the SRPM should include the source tarball. Either way, the tarball can be built from cloning source-build repo and running ./build-source-tarball.sh dotnet-%{runtime_version}; tar cvzf dotnet-%{runtime_version}.tar.gz dotnet-%{runtime_version}

Edit: fixed title. I will open a separate PR for 2.1.3/2.1.401

rebased onto 64ff682

5 years ago

aslice commented on line 13 of dotnet.spec 5 years ago

This went from 2%{?dist} to 1%{?dist}, is that number supposed to reset instead of increment?

aslice commented 5 years ago

Other than my one question, this looks fine to me.

omajid commented 5 years ago

RPM package versions are split into 2 pieces: the upstream version (called Version) and the RPM-version (called the Release). It's expected that Release is reset every time Version is bumped.

https://fedoraproject.org/wiki/Packaging:Versioning#Simple_versioning:

Use a Release: tag starting with 1 (never 0). Append the Dist tag. Increment the release (by 1) for each update you make. Reset to 1 whenever you change Version:.