This ticket has been created to track the following "cleanup" tasks associated with:
These "cleanup" tasks consist of the code review suggestions originally submitted for the ticket referenced above, that have not yet been addressed:
Also, as I look at this code, it occurs to me that it would make the
code a lot simpler if we simply defined a bunch of object variables for
the most commonly used options. So, in the init() method for
def __init__(self, deployer):
self.deployer = deployer
self.master_dict = deployer.master_dict
self.clone = config.str2bool(deployer.master_dict['pki_clone'])
self.subsystem = deployer.master_dict['pki_subsystem']
The the above becomes:
# Security Domain
if ((self.subsystem != "CA" or self.clone or self.subordinate) and\
We could start simple and do just the ConfigClient class, although the
ConfigurationFile class could really use this kind of simplification.
NOTE: The following original "cleanup" task:
has been moved to:
Initial patch for Stand-alone DRM cleanup tasks
Prior to check-in, the default value of 'pki_enable_access_log' in
'pki/base/server/etc/default.cfg' was changed from 'False' to 'True', and the appropriate information was changed in the 'pki/base/server/man/man5/pki_default.cfg.5' man page.
Checked-in to master:
Metadata Update from @mharmsen:
- Issue assigned to mharmsen
- Issue set to the milestone: 10.1 - 10/13 (October)
Dogtag PKI is moving from Pagure issues to GitHub issues. This means that existing or new
issues will be reported and tracked through Dogtag PKI's GitHub Issue tracker.
This issue has been cloned to GitHub and is available here:
If you want to receive further updates on the issue, please navigate to the
GitHub issue and click on Subscribe button.
Thank you for understanding, and we apologize for any inconvenience.
to comment on this ticket.