On November 29, 2017, dac.override@gmail.com filed the following issue:
You use "seobject". "seobject" is problematic since it hard codes identifiers that essentially ties it to "selinux-policy"
Even if it didn't, you still reference hard coded identifiers with it.
Example:
/usr/lib/python2.7/site-packages/pki/server/deployment/pkihelper.py:809
Please consider dropping your "special care for SELinux" (use of "seobject") as this essentially creates a hard dependency on specific selinux policy configuration. This forces in turn hard dependencies on consumers of dogtag (ipa server for example)
Steps to reproduce:
run "/usr/sbin/pkispawn -s CA -f /tmp/tmpoohh38fw" on a Fedora system that has SELinux enabled, but that does not enforce "selinux-policy" (ie. a Fedora system with custom policy configuration)
Actual results:
2017-11-29T10:41:43Z DEBUG Starting external process 2017-11-29T10:41:43Z DEBUG args=/usr/sbin/pkispawn -s CA -f /tmp/tmpoohh38fw 2017-11-29T10:41:44Z DEBUG Process finished, return code=1 2017-11-29T10:41:44Z DEBUG stdout= 2017-11-29T10:41:44Z DEBUG stderr=Traceback (most recent call last): File "/usr/sbin/pkispawn", line 39, in <module> from pki.server.deployment import pkiconfig as config File "/usr/lib/python2.7/site-packages/pki/server/deployment/__init__.py", line 31, in <module> from . import pkihelper as util File "/usr/lib/python2.7/site-packages/pki/server/deployment/pkihelper.py", line 56, in <module> import seobject File "/usr/lib64/python2.7/site-packages/seobject.py", line 1047, in <module> class portRecords(semanageRecords): File "/usr/lib64/python2.7/site-packages/seobject.py", line 1049, in portRecords valid_types = list(list(sepolicy.info(sepolicy.ATTRIBUTE, "port_type"))[0]["types"]) IndexError: list index out of range
Metadata Update from @mharmsen: - Custom field component adjusted to None - Custom field feature adjusted to None - Custom field origin adjusted to None - Custom field proposedmilestone adjusted to None - Custom field proposedpriority adjusted to None - Custom field reviewer adjusted to None - Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1518631 - Custom field type adjusted to None - Custom field version adjusted to None - Issue set to the milestone: 0.0 NEEDS_TRIAGE
Per PKI Team Meeting of 20180109: 10.6
Metadata Update from @mharmsen: - Issue set to the milestone: 10.6 (was: 0.0 NEEDS_TRIAGE)
Dogtag PKI is moving from Pagure issues to GitHub issues. This means that existing or new issues will be reported and tracked through Dogtag PKI's GitHub Issue tracker.
This issue has been cloned to GitHub and is available here: https://github.com/dogtagpki/pki/issues/2980
If you want to receive further updates on the issue, please navigate to the GitHub issue and click on Subscribe button.
Subscribe
Thank you for understanding, and we apologize for any inconvenience.
Metadata Update from @dmoluguw: - Issue close_status updated to: migrated - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.