The function read_environment_files() is used in KRA client. Internally it spawn a process for every call. This is pretty expensive and wasteful. It should be safe to cache the result and reuse the value in subsequent calls.
read_environment_files()
Metadata Update from @mharmsen: - Custom field component adjusted to None - Custom field feature adjusted to None - Custom field origin adjusted to None - Custom field proposedmilestone adjusted to None - Custom field proposedpriority adjusted to None - Custom field reviewer adjusted to None - Custom field type adjusted to None - Custom field version adjusted to None - Issue set to the milestone: 0.0 NEEDS_TRIAGE
Metadata Update from @mharmsen: - Issue assigned to mharmsen
Per meeting of 20171113 - 10.5 - critical
Metadata Update from @mharmsen: - Issue priority set to: critical - Issue set to the milestone: 10.5 (was: 0.0 NEEDS_TRIAGE)
Metadata Update from @mharmsen: - Assignee reset
Metadata Update from @mharmsen: - Issue assigned to ftweedal
Per discussions with ftweedal, moving to 10.6
Metadata Update from @mharmsen: - Issue set to the milestone: 10.6 (was: 10.5)
Metadata Update from @cheimes: - Issue assigned to cheimes (was: ftweedal)
https://review.gerrithub.io/400926
Use cached results of read_environment_files() KeyClient.get_client_keyset() no longer calls read_environment_files() in every call. The read_environment_files() spawns a shell process to source default and global pki.conf and update's the process' environ. The get_client_keyset() only parses the function, when KEY_WRAP_PARAMETER_SET env var is not present yet.
Use cached results of read_environment_files()
KeyClient.get_client_keyset() no longer calls read_environment_files() in every call. The read_environment_files() spawns a shell process to source default and global pki.conf and update's the process' environ.
The get_client_keyset() only parses the function, when KEY_WRAP_PARAMETER_SET env var is not present yet.
Metadata Update from @edewata: - Issue priority set to: major (was: critical)
Dogtag PKI is moving from Pagure issues to GitHub issues. This means that existing or new issues will be reported and tracked through Dogtag PKI's GitHub Issue tracker.
This issue has been cloned to GitHub and is available here: https://github.com/dogtagpki/pki/issues/2971
If you want to receive further updates on the issue, please navigate to the GitHub issue and click on Subscribe button.
Subscribe
Thank you for understanding, and we apologize for any inconvenience.
Metadata Update from @dmoluguw: - Issue close_status updated to: migrated - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.