#2400 SigningUnit.init() ignoring exceptions
Closed: migrated 3 years ago by dmoluguw. Opened 7 years ago by edewata.

The SigningUnit class currently catches and ignores all exceptions during initialization except for some exceptions that are specifically handled.

During CA installation the code ignores the following exception:

Property ca.signing.cacertnickname missing value
        at com.netscape.cmscore.base.PropConfigStore.getString(PropConfigStore.java:258)
        at com.netscape.ca.SigningUnit.init(SigningUnit.java:147)
        at com.netscape.ca.CertificateAuthority.initSigUnit(CertificateAuthority.java:1545)
        at com.netscape.ca.CertificateAuthority.init(CertificateAuthority.java:523)
        at com.netscape.cmscore.apps.CMSEngine.reinit(CMSEngine.java:1344)
        at com.netscape.certsrv.apps.CMS.reinit(CMS.java:191)
        at com.netscape.cms.servlet.csadmin.ConfigurationUtils.reInitSubsystem(ConfigurationUtils.java:2287)
        at org.dogtagpki.server.rest.SystemConfigService.initializeDatabase(SystemConfigService.java:780)
        at org.dogtagpki.server.ca.rest.CAInstallerService.initializeDatabase(CAInstallerService.java:98)
        at org.dogtagpki.server.rest.SystemConfigService.configure(SystemConfigService.java:179)
        at org.dogtagpki.server.rest.SystemConfigService.configure(SystemConfigService.java:121)

While this exception is considered "normal" during CA installation (due to improper initialization sequence), the code could also mask a real problem during runtime.

Proposed solution:
1. The SigningUnit initialization sequence should be fixed such that it doesn't throw an exception during CA installation.
2. The code in SigningUnit.init() that catches and ignores exceptions should be removed.


Per PKI Bug Council of 07/07/2016: 10.4

The code also hides actual runtime error (e.g. missing CA signing certificate). See also https://bugzilla.redhat.com/show_bug.cgi?id=1390319.

Metadata Update from @edewata:
- Issue set to the milestone: UNTRIAGED

7 years ago

Dogtag PKI is moving from Pagure issues to GitHub issues. This means that existing or new
issues will be reported and tracked through Dogtag PKI's GitHub Issue tracker.

This issue has been cloned to GitHub and is available here:
https://github.com/dogtagpki/pki/issues/2520

If you want to receive further updates on the issue, please navigate to the
GitHub issue and click on Subscribe button.

Thank you for understanding, and we apologize for any inconvenience.

Metadata Update from @dmoluguw:
- Issue close_status updated to: migrated
- Issue status updated to: Closed (was: Open)

3 years ago

Login to comment on this ticket.

Metadata