#1220 Improvement for ProfileSubsystem.isProfileEnable().
Closed: migrated 3 years ago by dmoluguw. Opened 9 years ago by edewata.

If the enable property in the profile configuration contains an invalid boolean value (e.g. "fals") the profile will be considered enabled. See the code below:

public class ProfileSubsystem ... {

    public boolean isProfileEnable(String id) {
        ...
        if (enable == null || enable.equals("false"))
            return false;
        else
            return true;
    }
}

Since a user may edit the profile config directly, there's a possibility for such error to happen. To reduce the risk of false enablement, a profile should only be considered enabled if it's explicitly set to "true".

public class ProfileSubsystem ... {

    public boolean isProfileEnable(String id) {
        ...
        return Boolean.valueOf(enable);
    }
}

See also: http://docs.oracle.com/javase/7/docs/api/java/lang/Boolean.html#valueOf(java.lang.String)


Proposed milestone: 10.2.x

Per Dogtag 10.2.X meeting of 01/14/2015: Milestone 10.2 Backlog

Per 10.2.3 TRIAGE meeting of 02/26/2015: 10.3

NOTE: Moved from 10.2 Backlog since it was not a documentation/man page issue.

I'll address in next round of LDAP profiles patches.

Metadata Update from @edewata:
- Issue set to the milestone: UNTRIAGED

7 years ago

Dogtag PKI is moving from Pagure issues to GitHub issues. This means that existing or new
issues will be reported and tracked through Dogtag PKI's GitHub Issue tracker.

This issue has been cloned to GitHub and is available here:
https://github.com/dogtagpki/pki/issues/1782

If you want to receive further updates on the issue, please navigate to the
GitHub issue and click on Subscribe button.

Thank you for understanding, and we apologize for any inconvenience.

Metadata Update from @dmoluguw:
- Issue close_status updated to: migrated
- Issue status updated to: Closed (was: Open)

3 years ago

Login to comment on this ticket.

Metadata