#1004 Improper invocation of getSubStore()
Closed: migrated 3 years ago by dmoluguw. Opened 9 years ago by edewata.

Currently some code calls PropertyConfigStore.getSubStore() and checks for null return value to detect missing properties (or other errors). Since getSubStore() always return an object, missing properties are not detected, and the code might proceed with a wrong assumption.

One solution is to add getSubStore(boolean create) which if set to false it will return a null if the property is missing. Then the current getSubStore() will call getSubStore(true) for backward compatibility.

Then all getSubStore() invocations should be inspected to make sure they are handling the return value properly. If necessary they should be changed to call getSubStore(false).

Proposed milestone: 10.3


Per PKI/389 Meeting of 05/19/2014, moving to Milestone 10.4.

Metadata Update from @edewata:
- Issue set to the milestone: UNTRIAGED

7 years ago

Dogtag PKI is moving from Pagure issues to GitHub issues. This means that existing or new
issues will be reported and tracked through Dogtag PKI's GitHub Issue tracker.

This issue has been cloned to GitHub and is available here:
https://github.com/dogtagpki/pki/issues/1570

If you want to receive further updates on the issue, please navigate to the
GitHub issue and click on Subscribe button.

Thank you for understanding, and we apologize for any inconvenience.

Metadata Update from @dmoluguw:
- Issue close_status updated to: migrated
- Issue status updated to: Closed (was: Open)

3 years ago

Login to comment on this ticket.

Metadata