From 452f66f8e9321a96c22423ea4ada8232ec677996 Mon Sep 17 00:00:00 2001 From: Valentin Vidic Date: Oct 26 2018 16:11:19 +0000 Subject: dlm_controld: check write return value plock.c: In function ‘write_result’: plock.c:691:2: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result] write(plock_device_fd, in, sizeof(struct dlm_plock_info)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ --- diff --git a/dlm_controld/plock.c b/dlm_controld/plock.c index 28f07e6..992fb16 100644 --- a/dlm_controld/plock.c +++ b/dlm_controld/plock.c @@ -687,8 +687,13 @@ static int add_waiter(struct lockspace *ls, struct resource *r, static void write_result(struct lockspace *ls, struct dlm_plock_info *in, int rv) { + int write_rv; + in->rv = rv; - write(plock_device_fd, in, sizeof(struct dlm_plock_info)); + write_rv = write(plock_device_fd, in, sizeof(struct dlm_plock_info)); + if (write_rv < 0) + log_debug("write_result: write error %d fd %d\n", + errno, plock_device_fd); } static void do_waiters(struct lockspace *ls, struct resource *r)