31751a5 dlm_controld: be sure we close logging at last

Authored and Committed by aring 2 years ago
    dlm_controld: be sure we close logging at last
    
    I currently try to debug the following:
    
    (gdb) bt
    0  _int_malloc (av=av@entry=0x7fd353ac2bc0 <main_arena>, bytes=bytes@entry=8192) at malloc.c:3755
    1  0x00007fd3537a04a6 in __libc_calloc (n=n@entry=1, elem_size=elem_size@entry=8192) at malloc.c:3445
    2  0x00007fd353792bd7 in __GI___open_memstream (bufloc=bufloc@entry=0x7ffc4edd2ea0, sizeloc=sizeloc@entry=0x7ffc4edd2ea8) at memstream.c:83
    3  0x00007fd35382cba4 in __GI___vsyslog_chk (pri=163, flag=1, fmt=0x5560190522da "%s", ap=0x7ffc4edd2f90) at ../misc/syslog.c:167
    4  0x00007fd35382d1e3 in __syslog_chk (pri=pri@entry=3, flag=flag@entry=1, fmt=fmt@entry=0x5560190522da "%s") at ../misc/syslog.c:129
    5  0x000055601904e114 in syslog (__fmt=0x5560190522da "%s", __pri=3) at /usr/include/bits/syslog.h:31
    6  log_level (name_in=<optimized out>, level_in=<optimized out>, fmt=0x55601905243e "abandoned lockspace %s") at logging.c:166
    7  0x000055601903a91e in loop () at main.c:1597
    8  main (argc=<optimized out>, argv=<optimized out>) at main.c:2161
    
    We see that the last thing in dlm_controld was log_level() then it
    crashed internal handling of libc and syslog().
    
    (gdb) f 6
    6  log_level (name_in=<optimized out>, level_in=<optimized out>, fmt=0x55601905243e "abandoned lockspace %s") at logging.c:166
    166                     syslog(level, "%s", log_str);
    
    We see that log_level() was called with a format string of "abandoned
    lockspace %s" and we only do that after leaving the main loop,
    dlm_controld was going to shutdown and crashed.
    
    The reason is that at this time the syslog logging was already closed by
    closelog() and we still tried to call syslog() and libc doesn't like it.
    We should be sure closing the log functionality is the last thing to do
    when exiting dlm_controld. This patch is doing that so that dlm_controld
    should not crash anymore.
    
    Reported-by: Barry Marson <bmarson@redhat.com>
    
        
file modified
+3 -1