#567 Wiki - fix header images
Closed: Fixed 6 years ago Opened 6 years ago by jibecfed.

phenomenon

Our wiki header looks broken: https://fedoraproject.org/wiki/L10N

reason

Most probably the design change of Fedora Wiki

recommendation

Here is the template: https://fedoraproject.org/wiki/Template:Header
I assume it's just a few pixel fix, I do care more about Localization than anything else, but I assume it would worth fixing all images, to be nice with every sub-project :)

thanks a lot for your help


@jibecfed at first I couldn't see it at all because I guess the firefox / adguard ad blocker blocked it. The ad blocker, among other selectors, has a selector that blocks:

img[width="468"][height="60"]

Once I disabled the ad blocker, I found the CSS causing the issue, it comes from load.php (must be some mediawiki thing:)

 div.floatright {
  float:right;
  clear:right;
  position:relative;
  margin:0.5em 0 0.8em 1.4em
 }

It's the clear: right; causing the issue to happen.

This also gives a bit of a gap between the right-most edge of the image and the right-most edge of the background for the banner. I spent some time with it and can't figure out why it's there. Negative margins won't fix it.

@ryanlerch any ideas?

Metadata Update from @duffy:
- Issue tagged with: easyfix

6 years ago

Metadata Update from @duffy:
- Issue tagged with: triaged

6 years ago

@ryanlerch have any ideas on this one? a bit stumped.

@ryanlerch have any ideas on this one? a bit stumped.

Hi @duffy

I wish to contribute to Fedora Design (Sent an email to the mailing list, yesterday). Stumbled upon this issue!

I am having a bit trouble in understanding what exactly is the problem with the header? It looks like this in my browser (Google Chrome, Ad block disabled)

Is the gap between divider and image the issue? or something else?

closing, looks fixed

Metadata Update from @duffy:
- Issue close_status updated to: Fixed

6 years ago

Login to comment on this ticket.

Metadata