PR#990: frontend: add link to builder-live log for chroot states - copr/copr

copr / copr

#990 frontend: add link to builder-live log for chroot states

Merged 4 years ago by msuchy. Opened 4 years ago by thrnciar.

copr/ thrnciar/copr state-builder-live-log-link into master

frontend: add link to builder-live log for chroot states

Tomas Hrnciar • 4 years ago

32b2613

file modified

		`@@ -911,6 +911,14 @@`
		`path = os.path.normpath(os.path.join(*parts))`
		`return urljoin(app.config["BACKEND_BASE_URL"], path)`

		`+ def backend_live_log(self, chroot):`
		`+ parts = ["results", self.copr.owner_name, self.copr_dirname,`
		`+ chroot.name, self.id_fixed_width + "-" + self.package.name,`
		`+ "builder-live.log" if chroot.status == StatusEnum("running")`
		`+ else "builder-live.log.gz"]`
		`+ path = os.path.normpath(os.path.join(*parts))`
		`+ return urljoin(app.config["BACKEND_BASE_URL"], path)`
		`+`
		`@property`
		`def source_json_dict(self):`
		`if not self.source_json:`

frontend/coprs_frontend/coprs/templates/coprs/detail/build.html

file modified

+5 -1

		`@@ -228,7 +228,11 @@`
		`{{ chroot.started_on\|time_ago(chroot.ended_on) }}`
		`</td>`
		`<td>`
		`- {{ build_state_text(chroot.state) }}`
		`+ {% if chroot.finished or chroot.state == "running" %}`
		`+ <a href="{{ build.backend_live_log(chroot) }}">{{ build_state_text(chroot.state) }}</a>`
		`+ {% else %}`
		`+ {{ build_state_text(chroot.state) }}`
		`+ {% endif %}`
		`</td>`
		`</tr>`
		`{% endfor %}`

thrnciar commented 4 years ago

Fixes: #951

praiskup commented 4 years ago

I see this:

praiskup commented on line 17 of frontend/coprs_frontend/coprs/models.py 4 years ago

I think we only need link to builder-live.log (or .log.gz) here, not import log at all. So I'd suggest adding only one function of name say backend_live_log().

rebased onto fca955cf8bdbf0ca93af012531940c9c54835035

4 years ago

praiskup commented 4 years ago