#981 frontend: really don't show srpm live-log when pending
Merged 4 years ago by praiskup. Opened 4 years ago by praiskup.
Unknown source fix-srpm-live-log-link  into  master

@@ -166,13 +166,14 @@

          <dt>SRPM build log:</dt>

            {% if build.source_status | state_from_num in ['pending', 'starting']  %}

I think it might be a good idea to have this condition provided by some Build property (in the same way we have Build.finished, Build.cancelable, Build.repeatable, ...). Not as a part of this PR though, I am just ranting.

              <dd> Build has not started yet </dd>

-           {% endif %}

+           {% else %}

            {% for url in build.get_import_log_urls(g.user.admin) %}

              <dd>

                <a href="{{ url }}">{{ url | basename }}</a>

                  {{ "," if not loop.last }}

              </dd>

            {% endfor %}

+           {% endif %}

          <dt> Built Packages:</dt>

          {% if build.built_packages %}

            {% for pkg in build.built_packages.split("\n"): %}

I think it might be a good idea to have this condition provided by some Build property (in the same way we have Build.finished, Build.cancelable, Build.repeatable, ...). Not as a part of this PR though, I am just ranting.

Pull-Request has been merged by praiskup

4 years ago